Closed Bug 879989 Opened 8 years ago Closed 7 years ago

Update testNavigateFTP.js to use ftp.mozqa.com

Categories

(Mozilla QA Graveyard :: Mozmill Tests, defect)

defect
Not set
normal

Tracking

(firefox26 fixed, firefox27 fixed, firefox28 fixed, firefox29 fixed, firefox-esr17 wontfix, firefox-esr24 fixed)

RESOLVED FIXED
Tracking Status
firefox26 --- fixed
firefox27 --- fixed
firefox28 --- fixed
firefox29 --- fixed
firefox-esr17 --- wontfix
firefox-esr24 --- fixed

People

(Reporter: andrei, Assigned: whimboo)

References

Details

Attachments

(2 files, 2 obsolete files)

We should move all our ftp dependency from ftp.mozilla.org to mozqa.com
We want more control over the assets we use.

Affected tests
==============

mozmill
-------
- mutt/mutt/tests/js/utils/pageload.js

mozmill-tests
-------------
- lib/tests/testDownloads.js
- tests/functional/restartTests/testAddons_installFromFTP/test1.js
- tests/functional/testLayout/testNavigateFTP.js


mozqa ftp server
================

If we do this, we'll also need to add a ftp server to mozqa.com
(In reply to Andrei Eftimie from comment #0)
> - mutt/mutt/tests/js/utils/pageload.js

This will be outside of the scope of this bug. It's a different product.

> mozqa ftp server
> ================
> 
> If we do this, we'll also need to add a ftp server to mozqa.com

We have one which can be found here: ftp://ftp.mozqa.com/
Whiteboard: [mentor=whimboo][lang=js][good first bug]
That annoys me already all the week that those tests are failing from within the office network. I will fix that.
Assignee: nobody → hskupin
Whiteboard: [mentor=whimboo][lang=js][good first bug]
I checked all this and testNavigateFTP.js is the only test we have to update here. The download manager test I would leave for the other bug which is about getting all of those unit tests fixed.
Status: NEW → ASSIGNED
Summary: Move ftp dependency from ftp.mozilla.org to mozqa.com → Update testNavigateFTP.js to use ftp.mozqa.com
Attached patch Patch v1 (obsolete) — Splinter Review
This updates the test and also adds a step to use the directory up link.
Attachment #759514 - Flags: review?(andreea.matei)
Comment on attachment 759514 [details] [diff] [review]
Patch v1

Review of attachment 759514 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.
Attachment #759514 - Flags: review?(andreea.matei) → review+
Landed on default:
http://hg.mozilla.org/qa/mozmill-tests/rev/76f1d6acc8d8

Given that this is used to limit the number of possible failures with external resources, I will backport the patch tomorrow.
Strange, this has been tested yesterday and it worked pretty well. Not sure if something in SCL3 trapped us here. I will have a look.
Ok, so the problem here is our Squid proxy we have in SCL3. It re-formats the whole page into HTML, so the elements as we see without it are not available. Lets hope we can get this fixed. I filed bug 880709 for it.
Depends on: 929931
I will have to update the patch regarding the new repository structure. But given that all nodes have been updated for the proxy configuration now and mozqa.com can be directly accessed, we can finally land this patch.
Attached patch patch v2 (obsolete) — Splinter Review
Attachment #759514 - Attachment is obsolete: true
Attachment #8347184 - Flags: review?(andreea.matei)
Comment on attachment 8347184 [details] [diff] [review]
patch v2

Review of attachment 8347184 [details] [diff] [review]:
-----------------------------------------------------------------

::: firefox/tests/remote/testLayout/testNavigateFTP.js
@@ +5,5 @@
>  "use strict";
>  
>  Cu.import("resource://gre/modules/Services.jsm");
>  
> +const TEST_DATA = "ftp://ftp.mozqa.com/"

Missing semicolon here, other than that it's all good.
Attachment #8347184 - Flags: review?(andreea.matei) → review+
Attached patch patch v2.1Splinter Review
Updated patch for the missing semicolon.
Attachment #8347184 - Attachment is obsolete: true
Attachment #8347189 - Flags: review+
Comment on attachment 8347189 [details] [diff] [review]
patch v2.1

Review of attachment 8347189 [details] [diff] [review]:
-----------------------------------------------------------------

Backported:
http://hg.mozilla.org/qa/mozmill-tests/rev/c130c858c761 (aurora)
http://hg.mozilla.org/qa/mozmill-tests/rev/580917070016 (beta)
http://hg.mozilla.org/qa/mozmill-tests/rev/e80086cb4811 (release)

The patch for esr24 needs an extra update, which will be up in a bit.
Attachment #8347189 - Flags: checkin+
Attached patch backport v1Splinter Review
Attachment #8347206 - Flags: review?(andreea.matei)
Comment on attachment 8347206 [details] [diff] [review]
backport v1

Review of attachment 8347206 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.
Attachment #8347206 - Flags: review?(andreea.matei) → review+
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
It seems we still have some faulty Proxy settings, at least in relationship to mm-ub-1204-32-1:
http://mozmill-daily.blargon7.com/#/remote/report/ca1869364f98dd0de71202e01e6678e5
Since the last comment was not clear to me if you are going to fix it or not, I updated the missing gsettings proxy setting on that machine. It should be fine now.
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.