879989 - Update testNavigateFTP.js to use ftp.mozqa.com

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Andrei Eftimie]

We should move all our ftp dependency from ftp.mozilla.org to mozqa.com
We want more control over the assets we use.

Affected tests
==============

mozmill
-------
- mutt/mutt/tests/js/utils/pageload.js

mozmill-tests
-------------
- lib/tests/testDownloads.js
- tests/functional/restartTests/testAddons_installFromFTP/test1.js
- tests/functional/testLayout/testNavigateFTP.js


mozqa ftp server
================

If we do this, we'll also need to add a ftp server to mozqa.com

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to Andrei Eftimie from comment #0)
> - mutt/mutt/tests/js/utils/pageload.js

This will be outside of the scope of this bug. It's a different product.

> mozqa ftp server
> ================
> 
> If we do this, we'll also need to add a ftp server to mozqa.com

We have one which can be found here: ftp://ftp.mozqa.com/

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

That annoys me already all the week that those tests are failing from within the office network. I will fix that.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I checked all this and testNavigateFTP.js is the only test we have to update here. The download manager test I would leave for the other bug which is about getting all of those unit tests fixed.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Patch v1

This updates the test and also adds a step to use the directory up link.

Comment 5

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 759514 [details] [diff] [review]
Patch v1

Review of attachment 759514 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Landed on default:
http://hg.mozilla.org/qa/mozmill-tests/rev/76f1d6acc8d8

Given that this is used to limit the number of possible failures with external resources, I will backport the patch tomorrow.

Comment 7

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Backed out due to failure 'could not find element Selector: .up' in testNavigateFTP.js

See: http://mozmill-ci.blargon7.com/#/functional/failure?branch=All&platform=All&from=2013-05-31&to=2013-06-07&test=%2FtestLayout%2FtestNavigateFTP.js&func=testNavigateFTP.js%3A%3AtestNavigateFTP

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Strange, this has been tested yesterday and it worked pretty well. Not sure if something in SCL3 trapped us here. I will have a look.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Ok, so the problem here is our Squid proxy we have in SCL3. It re-formats the whole page into HTML, so the elements as we see without it are not available. Lets hope we can get this fixed. I filed bug 880709 for it.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I will have to update the patch regarding the new repository structure. But given that all nodes have been updated for the proxy configuration now and mozqa.com can be directly accessed, we can finally land this patch.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: patch v2

Comment 12

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 8347184 [details] [diff] [review]
patch v2

Review of attachment 8347184 [details] [diff] [review]:
-----------------------------------------------------------------

::: firefox/tests/remote/testLayout/testNavigateFTP.js
@@ +5,5 @@
>  "use strict";
>  
>  Cu.import("resource://gre/modules/Services.jsm");
>  
> +const TEST_DATA = "ftp://ftp.mozqa.com/"

Missing semicolon here, other than that it's all good.

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: patch v2.1

Updated patch for the missing semicolon.

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Landed on default as:
http://hg.mozilla.org/qa/mozmill-tests/rev/c032352cf8e3

Comment 15

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 8347189 [details] [diff] [review]
patch v2.1

Review of attachment 8347189 [details] [diff] [review]:
-----------------------------------------------------------------

Backported:
http://hg.mozilla.org/qa/mozmill-tests/rev/c130c858c761 (aurora)
http://hg.mozilla.org/qa/mozmill-tests/rev/580917070016 (beta)
http://hg.mozilla.org/qa/mozmill-tests/rev/e80086cb4811 (release)

The patch for esr24 needs an extra update, which will be up in a bit.

Comment 16

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: backport v1

Comment 17

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 8347206 [details] [diff] [review]
backport v1

Review of attachment 8347206 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

Comment 18

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Landed on esr24 too:
http://hg.mozilla.org/qa/mozmill-tests/rev/70a8ce39838b

Comment 19

[Andrei Eftimie]

It seems we still have some faulty Proxy settings, at least in relationship to mm-ub-1204-32-1:
http://mozmill-daily.blargon7.com/#/remote/report/ca1869364f98dd0de71202e01e6678e5

Comment 20

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Since the last comment was not clear to me if you are going to fix it or not, I updated the missing gsettings proxy setting on that machine. It should be fine now.