Update testNavigateFTP.js to use ftp.mozqa.com

RESOLVED FIXED

Status

RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: andrei, Assigned: whimboo)

Tracking

unspecified

Firefox Tracking Flags

(firefox26 fixed, firefox27 fixed, firefox28 fixed, firefox29 fixed, firefox-esr17 wontfix, firefox-esr24 fixed)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Reporter)

Description

6 years ago
We should move all our ftp dependency from ftp.mozilla.org to mozqa.com
We want more control over the assets we use.

Affected tests
==============

mozmill
-------
- mutt/mutt/tests/js/utils/pageload.js

mozmill-tests
-------------
- lib/tests/testDownloads.js
- tests/functional/restartTests/testAddons_installFromFTP/test1.js
- tests/functional/testLayout/testNavigateFTP.js


mozqa ftp server
================

If we do this, we'll also need to add a ftp server to mozqa.com
(Assignee)

Comment 1

6 years ago
(In reply to Andrei Eftimie from comment #0)
> - mutt/mutt/tests/js/utils/pageload.js

This will be outside of the scope of this bug. It's a different product.

> mozqa ftp server
> ================
> 
> If we do this, we'll also need to add a ftp server to mozqa.com

We have one which can be found here: ftp://ftp.mozqa.com/
Whiteboard: [mentor=whimboo][lang=js][good first bug]
(Assignee)

Comment 2

6 years ago
That annoys me already all the week that those tests are failing from within the office network. I will fix that.
Assignee: nobody → hskupin
Whiteboard: [mentor=whimboo][lang=js][good first bug]
(Assignee)

Comment 3

6 years ago
I checked all this and testNavigateFTP.js is the only test we have to update here. The download manager test I would leave for the other bug which is about getting all of those unit tests fixed.
Status: NEW → ASSIGNED
Summary: Move ftp dependency from ftp.mozilla.org to mozqa.com → Update testNavigateFTP.js to use ftp.mozqa.com
(Assignee)

Comment 4

6 years ago
Created attachment 759514 [details] [diff] [review]
Patch v1

This updates the test and also adds a step to use the directory up link.
Attachment #759514 - Flags: review?(andreea.matei)
Comment on attachment 759514 [details] [diff] [review]
Patch v1

Review of attachment 759514 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.
Attachment #759514 - Flags: review?(andreea.matei) → review+
(Assignee)

Comment 6

6 years ago
Landed on default:
http://hg.mozilla.org/qa/mozmill-tests/rev/76f1d6acc8d8

Given that this is used to limit the number of possible failures with external resources, I will backport the patch tomorrow.
status-firefox21: --- → affected
status-firefox22: --- → affected
status-firefox23: --- → affected
status-firefox24: --- → fixed
status-firefox-esr17: --- → affected
Backed out due to failure 'could not find element Selector: .up' in testNavigateFTP.js

See: http://mozmill-ci.blargon7.com/#/functional/failure?branch=All&platform=All&from=2013-05-31&to=2013-06-07&test=%2FtestLayout%2FtestNavigateFTP.js&func=testNavigateFTP.js%3A%3AtestNavigateFTP
status-firefox24: fixed → affected
(Assignee)

Comment 8

6 years ago
Strange, this has been tested yesterday and it worked pretty well. Not sure if something in SCL3 trapped us here. I will have a look.
(Assignee)

Updated

6 years ago
Depends on: 880709
(Assignee)

Comment 9

6 years ago
Ok, so the problem here is our Squid proxy we have in SCL3. It re-formats the whole page into HTML, so the elements as we see without it are not available. Lets hope we can get this fixed. I filed bug 880709 for it.
(Assignee)

Updated

5 years ago
Depends on: 929931
No longer depends on: 880709
(Assignee)

Comment 10

5 years ago
I will have to update the patch regarding the new repository structure. But given that all nodes have been updated for the proxy configuration now and mozqa.com can be directly accessed, we can finally land this patch.
status-firefox21: affected → ---
status-firefox22: affected → ---
status-firefox23: affected → ---
status-firefox24: affected → ---
status-firefox26: --- → affected
status-firefox27: --- → affected
status-firefox28: --- → affected
status-firefox29: --- → affected
status-firefox-esr17: affected → wontfix
status-firefox-esr24: --- → affected
(Assignee)

Comment 11

5 years ago
Created attachment 8347184 [details] [diff] [review]
patch v2
Attachment #759514 - Attachment is obsolete: true
Attachment #8347184 - Flags: review?(andreea.matei)
Comment on attachment 8347184 [details] [diff] [review]
patch v2

Review of attachment 8347184 [details] [diff] [review]:
-----------------------------------------------------------------

::: firefox/tests/remote/testLayout/testNavigateFTP.js
@@ +5,5 @@
>  "use strict";
>  
>  Cu.import("resource://gre/modules/Services.jsm");
>  
> +const TEST_DATA = "ftp://ftp.mozqa.com/"

Missing semicolon here, other than that it's all good.
Attachment #8347184 - Flags: review?(andreea.matei) → review+
(Assignee)

Comment 13

5 years ago
Created attachment 8347189 [details] [diff] [review]
patch v2.1

Updated patch for the missing semicolon.
Attachment #8347184 - Attachment is obsolete: true
Attachment #8347189 - Flags: review+
(Assignee)

Comment 14

5 years ago
Landed on default as:
http://hg.mozilla.org/qa/mozmill-tests/rev/c032352cf8e3
status-firefox29: affected → fixed
(Assignee)

Comment 15

5 years ago
Comment on attachment 8347189 [details] [diff] [review]
patch v2.1

Review of attachment 8347189 [details] [diff] [review]:
-----------------------------------------------------------------

Backported:
http://hg.mozilla.org/qa/mozmill-tests/rev/c130c858c761 (aurora)
http://hg.mozilla.org/qa/mozmill-tests/rev/580917070016 (beta)
http://hg.mozilla.org/qa/mozmill-tests/rev/e80086cb4811 (release)

The patch for esr24 needs an extra update, which will be up in a bit.
Attachment #8347189 - Flags: checkin+
(Assignee)

Updated

5 years ago
status-firefox26: affected → fixed
status-firefox27: affected → fixed
status-firefox28: affected → fixed
(Assignee)

Comment 16

5 years ago
Created attachment 8347206 [details] [diff] [review]
backport v1
Attachment #8347206 - Flags: review?(andreea.matei)
Comment on attachment 8347206 [details] [diff] [review]
backport v1

Review of attachment 8347206 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.
Attachment #8347206 - Flags: review?(andreea.matei) → review+
(Assignee)

Comment 18

5 years ago
Landed on esr24 too:
http://hg.mozilla.org/qa/mozmill-tests/rev/70a8ce39838b
status-firefox-esr24: affected → fixed
(Assignee)

Updated

5 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Reporter)

Comment 19

5 years ago
It seems we still have some faulty Proxy settings, at least in relationship to mm-ub-1204-32-1:
http://mozmill-daily.blargon7.com/#/remote/report/ca1869364f98dd0de71202e01e6678e5
(Assignee)

Comment 20

5 years ago
Since the last comment was not clear to me if you are going to fix it or not, I updated the missing gsettings proxy setting on that machine. It should be fine now.
You need to log in before you can comment on or make changes to this bug.