879994 - LightweightThemeManager should allow lightweight themes to be temporarily disabled

Status: RESOLVED WONTFIX

(Toolkit :: Add-ons Manager, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

There may be times where a lightweight theme can be temporarily disabled, for example when entering customization mode.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

Comment 2

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Comment on attachment 758872 [details] [diff] [review]
Patch

Review of attachment 758872 [details] [diff] [review]:
-----------------------------------------------------------------

So... how do you plan on re-enabling?

Also: tests, plzkthx.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

The theme can be re-enabled by calling LightweightThemeManager.themeChanged(LightweightThemeManager.currentTheme);

Comment 4

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Yea, but that's non-obvious. It also does a lot of extra stuff. I'd rather have a dedicated API function to undo what temporarilyDisableTheme does (even if its just making that accept a boolean toggle parameter).

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch v2 with tests

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch v2.1 with tests

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/projects/ux/rev/2ebd4237b7b2

Comment 8

[:Gijs (he/him)]

This was backed out in favour of the fix in bug 885066.

https://hg.mozilla.org/projects/ux/rev/81ef9027114f

Given that bug and its resolution, I guess this one should be marked WONTFIX.