880097 - Only retrieve database fetched values if requested

Status: RESOLVED FIXED

(Bugzilla :: WebService, defect)

Description

[Simon Green]

As part of BRC's review of RPC performance, we found that there were some values that were being retrieved from the database, even if they were not requested. While each call takes less than a millisecond, when you are retrieving tens of thousands of bugs, retrieving unwanted information can lead to a significant delay.

Comment 1

[Simon Green]

Attachment: v1 patch

Well that was a little embarrassing. Most of the database based values are BRC customisations (e.g. for multiple aliases). Nonetheless, there were three calls that use database calls.

  -- simon

Comment 2

[:glob ✱]

Comment on attachment 758952 [details] [diff] [review]
v1 patch

r=glob

Comment 3

[Frédéric Buclin]

Comment on attachment 758952 [details] [diff] [review]
v1 patch

>         classification   => $self->type('string', $bug->classification),

Why isn't classification also included in a filter_wants check? It also requires an extra DB call.

Comment 4

[:glob ✱]

Comment on attachment 758952 [details] [diff] [review]
v1 patch

lpsolit pointed out that classification should get the same treatment.

Comment 5

[Simon Green]

Attachment: v2 patch

Comment 6

[:glob ✱]

Comment on attachment 761204 [details] [diff] [review]
v2 patch

r=glob

Comment 7

[Simon Green]

Attachment: v3 patch

Oh dear. Don't know how I missed the blooper in the last patch.

Comment 8

[:glob ✱]

Comment on attachment 763306 [details] [diff] [review]
v3 patch

r=glob

Comment 9

[Simon Green]

$ bzr commit --fixes mozilla:880097
Committing to: bzr+ssh://bmo/bugzilla/4.4/                                     
modified Bugzilla/WebService/Bug.pm
Committed revision 8570.                                                       

Committing to: bzr+ssh://bmo/bugzilla/trunk/                                   
modified Bugzilla/WebService/Bug.pm
Committed revision 8639.

Comment 10

[Frédéric Buclin]

(In reply to Simon Green from comment #9)
> Committing to: bzr+ssh://bmo/bugzilla/4.4/                                  

Hum, this shortcut means that revision numbers are no longer linkifed.

Comment 11

[Simon Green]

(In reply to Frédéric Buclin from comment #10)
> (In reply to Simon Green from comment #9)
> > Committing to: bzr+ssh://bmo/bugzilla/4.4/                                  
> 
> Hum, this shortcut means that revision numbers are no longer linkifed.

Yeah, sorry about that. Byron pointed that out to me too.

http://logbot.glob.com.au/?c=mozilla%23bugzilla&s=17%20Jun%202013&e=17%20Jun%202013#c1279400

I've updated my ssh config file so that future commits should be linkified.

  -- simon