Closed
Bug 880158
Opened 11 years ago
Closed 11 years ago
Remove glibc backtrace() native unwind on Linux
Categories
(Core :: Gecko Profiler, defect)
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: jseward, Assigned: jseward)
Details
Attachments
(1 file)
|
2.27 KB,
patch
|
BenWa
:
review+
|
Details | Diff | Splinter Review |
Let's get rid of the glibc backtrace() facility on Linux. It is never
going to work reliably due to the usual malloc-malloc deadlocking problem.
I think it is less deadlocky with jemalloc because jemalloc is (as I
understand it) does less locking than glibc malloc, but for sure it
routinely deadlocks for me when building FX with --disable-jemalloc.
|
Assignee | |
Comment 1•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
Attachment #762632 -
Flags: review?(bgirard)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 762632 [details] [diff] [review]
Patch
Review of attachment 762632 [details] [diff] [review]:
-----------------------------------------------------------------
::: tools/profiler/TableTicker.cpp
@@ -41,5 @@
>
> // JS
> #include "jsdbgapi.h"
>
> // we eventually want to make this runtime switchable
Can you also remove this comment?
Attachment #762632 -
Flags: review?(bgirard) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
|
||
Comment 4•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in
before you can comment on or make changes to this bug.
Description
•