Closed Bug 880158 Opened 8 years ago Closed 8 years ago

Remove glibc backtrace() native unwind on Linux

Categories

(Core :: Gecko Profiler, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: jseward, Assigned: jseward)

Details

Attachments

(1 file)

Let's get rid of the glibc backtrace() facility on Linux.  It is never
going to work reliably due to the usual malloc-malloc deadlocking problem.
I think it is less deadlocky with jemalloc because jemalloc is (as I 
understand it) does less locking than glibc malloc, but for sure it
routinely deadlocks for me when building FX with --disable-jemalloc.
Attached patch PatchSplinter Review
Attachment #762632 - Flags: review?(bgirard)
Comment on attachment 762632 [details] [diff] [review]
Patch

Review of attachment 762632 [details] [diff] [review]:
-----------------------------------------------------------------

::: tools/profiler/TableTicker.cpp
@@ -41,5 @@
>  
>  // JS
>  #include "jsdbgapi.h"
>  
>  // we eventually want to make this runtime switchable

Can you also remove this comment?
Attachment #762632 - Flags: review?(bgirard) → review+
https://hg.mozilla.org/mozilla-central/rev/80c3c00e0b3c
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.