880292 - [Contacts] Gmail import is using a personal developer keys

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Francisco Jordano [:arcturus] [:francisco]]

We should use a 'mozilla team' keys instead of the personal dev keys used now.

Comment 1

[Francisco Jordano [:arcturus] [:francisco]]

Dylan, James Lal commented me that you could be the person to ask to create those keys under a mozilla team account.

Is that  right?

Thanks,
F.

Comment 2

[Dylan Oliver [:doliver]]

Yes, we can do that. What API services does the import require?

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Hi Dylan,

Right now we are not asking for any specific api since we are using google contacts api v3:

https://developers.google.com/google-apps/contacts/v3/

that just requires OAuth 2.0 access.

So we will need just the client ids.

Cheers,
F.

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Forgot to mention the rediectus uri's 

Redirect URIs:	https://serene-cove-3587.herokuapp.com/liveowd/oauth2_new/flow_live.html
JavaScript origins:	https://serene-cove-3587.herokuapp.com

Those urls are not hitten by the final user, as we implemented the new Oauth 2.0 redirect mechanism via manifest.

Cheers.

Comment 5

[Dylan Oliver [:doliver]]

I created a new key under the Mozilla account and sent it to Francisco. Assigning to him to replace the personal key.

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: Pointer to PR 10298

Tried on the phone and now when asking for user identity, I got the following developer:

Mozilla Firefox OS

The import working good.

Thanks!

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Changing to correct flags as the only version affected is 1.1

Asking for leo? since the change risk is minimun and the user impact (asking for credentials coming from Mozilla) is high.

Actually this patch just changes a key id, no code involved here.

Thanks!
F.

Comment 8

[Jose Manuel Cantera]

https://github.com/mozilla-b2g/gaia/commit/9aa39aae3440c1921636253ec62c1ac2d0fde861

Comment 9

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 9aa39aae3440c1921636253ec62c1ac2d0fde861 to:
v1-train: dfe98487809a226cbcc727ce0a0b90212698af5d

Comment 10

[John Ford [:jhford] CET/CEST Berlin Time]

1.1hd: dfe98487809a226cbcc727ce0a0b90212698af5d