Closed Bug 880353 Opened 11 years ago Closed 11 years ago

[STK] "STK_CMD_DISPLAY_TEXT" code refactoring

Categories

(Firefox OS Graveyard :: Gaia, defect)

Product:
Firefox OS Graveyard
Component:
Gaia
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:leo+, b2g18 fixed, b2g-v1.1hd fixed)

Status:
RESOLVED FIXED
Milestone:
1.1 QE3 (26jun)
Project Flags:
blocking-b2g leo+
Tracking Flags:
Tracking Status
b2g18 --- fixed
b2g-v1.1hd --- fixed

People

(Reporter: noemi, Assigned: frsela)

References

Details

(Whiteboard: QARegressExclude)

Attachments

(1 file, 3 obsolete files)

STK_CMD_DISPLAY_TEXT moved to system
363 bytes, text/html
timdream
: review+
Details 
STK code refactoring moving "STK_CMD_DISPLAY_TEXT" code from settings to system
Assignee: nobody → frsela
Blocks: 875679
I don't ask for r? since this patch shall be landed after 880333.
I'll create the PR when 880333 lands
Attachment #763468 - Flags: feedback?(kaze)

        Attachment #763468 -
        Attachment is obsolete: true

        Attachment #763468 -
        Flags: feedback?(kaze)

        Attachment #763469 -
        Flags: feedback?(kaze)

    
    

    
  


  
I'll ask for review when other bugs dependencies are satisfied, meanwhile I ask for some feedback.
Thanks in advance.

        Attachment #763469 -
        Attachment is obsolete: true

        Attachment #763469 -
        Flags: feedback?(kaze)

        Attachment #764752 -
        Flags: feedback?(kaze)

    
    

    
  
Milestoning for QE3 (due by 6/24), since this blocks bug 875679 which blocks 865985 (QE3 milestoned).
Target Milestone: --- → 1.1 QE3 (24jun)

    
    

    
  
Notice that Bug 881672 needs to be uplifted to v1-train in order to enable STK/ICC testing
Depends on: 881672

    
  
blocking-b2g: --- → leo?

    
  
blocking-b2g: leo? → leo+

    
    

    
  


  

        Attachment #764752 -
        Attachment is obsolete: true

        Attachment #764752 -
        Flags: feedback?(kaze)

        Attachment #766531 -
        Flags: review?(timdream)

        Attachment #766531 -
        Flags: review?(timdream) → review+

    
    

    
  
Landed: https://github.com/mozilla-b2g/gaia/commit/02c9780e4c8235444fd849f14e3c400333dd9df7
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED

    
    

    
  
I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 02c9780e4c8235444fd849f14e3c400333dd9df7
  <RESOLVE MERGE CONFLICTS>
  git commit
Flags: needinfo?(frsela)
Depends on: 880333
Flags: needinfo?(frsela)

    
    

    
  
Uplifted: https://github.com/mozilla-b2g/gaia/commit/ff1fd164f88efda20fe1c3cc415b50aee0b38ad3

(In reply to John Ford [:jhford] -- please use 'needinfo?' instead of a CC from comment #8)
> I was not able to uplift this bug to v1-train.  If this bug has dependencies
> which are not marked in this bug, please comment on this bug.  If this bug
> depends on patches that aren't approved for v1-train, we need to re-evaluate
> the approval.  Otherwise, if this is just a merge conflict, you might be
> able to resolve it with:
> 
>   git checkout v1-train
>   git cherry-pick -x -m1 02c9780e4c8235444fd849f14e3c400333dd9df7
>   <RESOLVE MERGE CONFLICTS>
>   git commit

    
    

    
  
1.1hd: ff1fd164f88efda20fe1c3cc415b50aee0b38ad3

          status-b2g-v1.1hd:
          --- → fixed

    
  
Whiteboard: QARegressExclude

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: