mach: bootstrap support for debian

RESOLVED FIXED in mozilla24

Status

()

Core
Build Config
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: K Everets, Assigned: K Everets)

Tracking

unspecified
mozilla24
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
Created attachment 759311 [details] [diff] [review]
Bootstrap support for Debian

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20130606 Firefox/24.0 (Nightly/Aurora)
Build ID: 20130606082201

Steps to reproduce:

Attempted to run:

./mach bootstrap


Actual results:

$ ./mach bootstrap
Error running mach:

    ['bootstrap']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.

You should consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

NotImplementedError: Bootstrap support for this Linux distro not yet available.

  File "/home/keverets/src/mozilla-central.git/python/mozboot/mozboot/mach_commands.py", line 24, in bootstrap
    bootstrapper.bootstrap()
  File "/home/keverets/src/mozilla-central.git/python/mozboot/mozboot/bootstrap.py", line 53, in bootstrap
    raise NotImplementedError('Bootstrap support for this Linux '



Expected results:

$ ./mach bootstrap
Executing as root: sudo apt-get build-dep iceweasel
[sudo] password for keverets: 
Reading package lists... Done
Building dependency tree       
Reading state information... Done
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
Executing as root: sudo apt-get install autoconf2.13 libasound2-dev libcurl4-openssl-dev libiw-dev libnotify-dev libxt-dev mercurial mesa-common-dev uuid yasm
Reading package lists... Done
Building dependency tree       
Reading state information... Done
libasound2-dev is already the newest version.
autoconf2.13 is already the newest version.
libcurl4-openssl-dev is already the newest version.
libnotify-dev is already the newest version.
libxt-dev is already the newest version.
mercurial is already the newest version.
mesa-common-dev is already the newest version.
uuid is already the newest version.
libiw-dev is already the newest version.
yasm is already the newest version.
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.

Your system should be ready to build Firefox! If you have not already,
obtain a copy of the source code by running:

    hg clone https://hg.mozilla.org/mozilla-central

Or, if you prefer Git:

    git clone git://github.com/mozilla/mozilla-central.git
Assignee: nobody → kevin
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Comment on attachment 759311 [details] [diff] [review]
Bootstrap support for Debian

Thank you for the patch! :-)

Asking gps for review so this doesn't get missed.
Attachment #759311 - Flags: review?(gps)

Comment 2

4 years ago
Comment on attachment 759311 [details] [diff] [review]
Bootstrap support for Debian

Review of attachment 759311 [details] [diff] [review]:
-----------------------------------------------------------------

Looking good!

You'll need to add a reference to debian.py in bin/bootstrap.py. Once you have that, I'll r+.
Attachment #759311 - Flags: review?(gps) → feedback+
(Assignee)

Comment 3

4 years ago
Created attachment 761981 [details] [diff] [review]
Bootstrap support for Debian - updated

Added the requested reference in bin/bootstrap.py.  Sorry for the omission, and thanks for the feedback!
Attachment #759311 - Attachment is obsolete: true
Attachment #761981 - Flags: review?(gps)

Comment 4

4 years ago
Comment on attachment 761981 [details] [diff] [review]
Bootstrap support for Debian - updated

Review of attachment 761981 [details] [diff] [review]:
-----------------------------------------------------------------

You don't have to apologize for the omission - it's easy to miss!

Anyway, this looks good! It can be committed with DONTBUILD since this isn't part of the build system per se.

Add "checkin-needed" to the bug keywords if you don't have repository push access and someone will magically come along and check this in for you.
Attachment #761981 - Flags: review?(gps) → review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/37b52a498f43
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/37b52a498f43
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.