Closed
Bug 880389
Opened 13 years ago
Closed 13 years ago
Only require reason tags if the tree status is being set to closed
Categories
(Release Engineering :: General, defect)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: emorley)
References
Details
Attachments
(1 file)
|
5.63 KB,
patch
|
catlee
:
review+
|
Details | Diff | Splinter Review |
I'm so used to using the restore buttons in treestatus normally, that my local testing of bug 871588 missed this rather obvious pitfall of making reason tags mandatory: We normally don't want to set them when marking a tree open or approval required - only closed. My bad!
I'm not sure whether we should be making them optional or forbidden for 'open' - but for 'approval required' it seems useful to leave them as optional (given we could have set approval required due to lack of capacity around release time or something).
Anyway for now, I've left it allowable to set tags for open and approval required - and we can revisit when I overhaul the templates as part of reducing duplication (very soon). (I thought we could perhaps hide the tags UI when 'open' is selected etc).
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #759336 -
Flags: review?(catlee)
|
|
||
Updated•13 years ago
|
Attachment #759336 -
Flags: review?(catlee) → review+
|
|
Assignee | |
Comment 2•13 years ago
|
||
|
|
Assignee | |
Comment 3•13 years ago
|
||
In production :-)
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
Product: Webtools → Tree Management
|
|
||
Updated•10 years ago
|
Product: Tree Management → Release Engineering
|
|
||
Updated•4 years ago
|
Component: Applications: TreeStatus → General
You need to log in
before you can comment on or make changes to this bug.
Description
•