880393 - ListView rows in about:home should fade, and not ellipsize

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Sriram Ramasubramanian [:sriram]]

ListView rows in about:home should not ellipsize the text. They should instead fade at the end.

Comment 1

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

This adds a faded text view with a new attribute "fadeWith". There are other views in about:home (like the top sites grid view) that also uses fading, but of different size. This can be used there as well.

Somehow setting singleLine and ellipsize in styles.xml is not getting into the TextView. I'm investigating that. Meanwhile, those attributes are added to layout files directly, and this patch (works and) is safe to land.

Comment 2

[Sriram Ramasubramanian [:sriram]]

The last color here should be 0x0 (transparent)

 new int[] { color, color, 0xFFFFFFFF},

I can change it when I push it.

Comment 3

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

Fixed the styling issue and the transparency.
The styling issue was because we had a values-16 folder, which I didn't see.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 759410 [details] [diff] [review]
Patch

Looks fine, but I always worry about performance of rendering gradients.

Comment 5

[Sriram Ramasubramanian [:sriram]]

http://hg.mozilla.org/projects/fig/rev/2b2bdaae5bd3

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/2b2bdaae5bd3