880434 - Deploy clang static analysis builders to all mozilla-central trees

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Joshua Cranmer [:jcranmer]]

Now that the build is running green on mozilla-central, can this be rolled out to all the trees that feed into mozilla-central so it can be enabled in the default view on tbpl?

Comment 1

[Ed Morley [:emorley]]

For reference, runtime is 80mins x 1 platform per push, which seems more than reasonable to me :-)

Comment 2

[(no longer active)]

Yes, we should absolutely do this!  Thanks for your hard work, Joshua!

Comment 3

[Gregory Szorc [:gps]]

Coop: Is this on RelEng's radar?

Comment 4

[Chris Cooper [:coop] (he/him)]

Attachment: Enable static analysis on all branches derived from m-c

Comment 5

[Chris Cooper [:coop] (he/him)]

Comment on attachment 764906 [details] [diff] [review]
Enable static analysis on all branches derived from m-c

Review of attachment 764906 [details] [diff] [review]:
-----------------------------------------------------------------

Note: I can break this out into its own section if you prefer. It's currently lumped in with the "32-bit linux in a x86_64 env" changes, but only because the affected branches are the same.

Comment 6

[Chris Cooper [:coop] (he/him)]

Attachment: Enable static analysis on all branches derived from m-c, v2

Moved it into its own section. No point having it conflated with a merge day section that will go away.

Comment 7

[Gregory Szorc [:gps]]

Comment on attachment 764918 [details] [diff] [review]
Enable static analysis on all branches derived from m-c, v2

Review of attachment 764918 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozilla/config.py
@@ +2118,5 @@
>  
> +# Static analysis happens only on m-c and derived branches.
> +for branch in ("mozilla-aurora", "mozilla-beta", "mozilla-release",
> +               "mozilla-b2g18", "mozilla-b2g18_v1_0_1",
> +               "mozilla-b2g18_v1_1_0_hd", "mozilla-esr17"):

I'm not sure if static analysis will work in the older esr17 and b2g18 branches.

Comment 8

[(no longer active)]

(In reply to comment #7)
> Comment on attachment 764918 [details] [diff] [review]
>   --> https://bugzilla.mozilla.org/attachment.cgi?id=764918
> Enable static analysis on all branches derived from m-c, v2
> 
> Review of attachment 764918 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: mozilla/config.py
> @@ +2118,5 @@
> >  
> > +# Static analysis happens only on m-c and derived branches.
> > +for branch in ("mozilla-aurora", "mozilla-beta", "mozilla-release",
> > +               "mozilla-b2g18", "mozilla-b2g18_v1_0_1",
> > +               "mozilla-b2g18_v1_1_0_hd", "mozilla-esr17"):
> 
> I'm not sure if static analysis will work in the older esr17 and b2g18
> branches.

It won't.  We should be targeting central (24) and aurora when 24 goes to aurora, etc.

Comment 9

[Chris Cooper [:coop] (he/him)]

(In reply to :Ehsan Akhgari (needinfo? me!) from comment #8)
> It won't.  We should be targeting central (24) and aurora when 24 goes to
> aurora, etc.

Our configs are confusing. That stanza if removing static analysis builds on those release branches.

Comment 10

[Chris Cooper [:coop] (he/him)]

Comment on attachment 764918 [details] [diff] [review]
Enable static analysis on all branches derived from m-c, v2

https://hg.mozilla.org/build/buildbot-configs/rev/18ad18fb9453

Comment 11

[Kim Moir [:kmoir] ET]

In production