880513 - Sides of AwesomeScreen are padded with light blue and look broken on tablets

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Brian Nicholson (:bnicholson)]

STR:
1) Open AwesomeScreen
2) Type something

See screenshot. Haven't yet tested this on anything other than Fx24. Reproducible on Galaxy Note 10.1.

Comment 1

[Brian Nicholson (:bnicholson)]

Attachment: screenshot

Comment 2

[Aaron Train [:aaronmt]]

Device or OS specific I guess, I don't see this on the Transformer TF201 (4.1)

Comment 3

[Brian Nicholson (:bnicholson)]

See this on Fx23, but not 22.

Comment 4

[Lukas Blakk [:lsblakk] use ?needinfo]

Let's get a regression window - can someone confirm it hasn't always been like this on certain devices?

Comment 5

[Teodora Vermesan (:TeoVermesan)]

I see this issue on Samsung Galaxy Tab (Android 4.0.4) and Asus EEE Transformers (Android 4.0.3) only on Firefox for Android 23 and 24.
I will try to find a regression window.

Comment 6

[Teodora Vermesan (:TeoVermesan)]

The regressionwindow-wanted:
mozilla central:
good build: 12-04-2013
bad build:  13-04-2013

pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=7b8ed29c6bc0&tochange=24a6b5ed51e3

The tinderbox inbound builds are missing since the issue is older than one month.

Comment 7

[Aaron Train [:aaronmt]]

Bug 823644?

Comment 8

[Sriram Ramasubramanian [:sriram]]

(In reply to Teodora Vermesan (:TeoVermesan) from comment #6)
> The regressionwindow-wanted:
> mozilla central:
> good build: 12-04-2013
> bad build:  13-04-2013
> 
> pushlog:
> http://hg.mozilla.org/mozilla-central/
> pushloghtml?fromchange=7b8ed29c6bc0&tochange=24a6b5ed51e3
> 
> The tinderbox inbound builds are missing since the issue is older than one
> month.

It was caused by a patch for overdraw. Please don't find a regression range. I know what bug it is :D

Comment 9

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

This patch sets the padding to the entire tabs section and not just the view-pager.
This way, the sides are blue and the list is contained in-between.

I need to check with Ian on how the tab-widget should be. I would post a patch if we wants to change something there.

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

this will need uplift to aurora and beta

Comment 11

[Lukas Blakk [:lsblakk] use ?needinfo]

Please nominate for uplift.

Comment 12

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

This is the right patch. :(
AwesomeBar needs few new styles for its lists (for the padding -- which was removed earlier). This gives the exact same result as in current release version of Firefox -- with no overdraw! win! win! WIN!

Comment 13

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b6a7f3664655

Comment 14

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 772256 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Overdraw in awesomebar
User impact if declined: Side of search suggestion opt-in prompt will be in a light color.
Testing completed (on m-c, etc.): Landed in m-i on 07/08. This is based on old code -- rebased for lastest code.
Risk to taking this patch (and alternatives if risky): Very less. This uses the same logic.
String or IDL/UUID changes made by this patch: None.

Comment 15

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b6a7f3664655

Comment 16

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/5f6979e4afaa
https://hg.mozilla.org/releases/mozilla-beta/rev/239cafd191b9

Comment 17

[Teodora Vermesan (:TeoVermesan)]

Verified fixed on:
Build: Firefox for Android 25.0a1( 2013-07-14)
Device: Samsung Galaxy Tab
OS: Android 4.0.4

Comment 18

[Teodora Vermesan (:TeoVermesan)]

Verified fixed on:
Build: Firefox for Android 24.0a2( 2013-07-16)
Device: Acer Iconia
OS: Android 3.2

Comment 19

[Teodora Vermesan (:TeoVermesan)]

Verified fixed on:
Build: Firefox for Android 23.0b6( 2013-07-17)
Device: Acer Iconia
OS: Android 3.2