880576 - Error in parsing value for '-moz-margin-end'. Declaration dropped.

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

[00:13:51.367] Error in parsing value for '-moz-margin-end'.  Declaration dropped. @ chrome://browser/skin/customizableui/panelUIOverlay.css:414

[00:13:51.368] Error in parsing value for '-moz-margin-start'.  Declaration dropped. @ chrome://browser/skin/customizableui/panelUIOverlay.css:420

'none' is not a valid value for -moz-margin-end or -moz-margin-start. You probably want '0'.

Comment 1

[Mike de Boer [:mikedeboer]]

Attachment: Use correct value for -moz-margin-*

Thanks for noticing that in your endless stdout stream!

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 759720 [details] [diff] [review]
Use correct value for -moz-margin-*

Review of attachment 759720 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Mike de Boer [:mikedeboer] from comment #1)
> Created attachment 759720 [details] [diff] [review]
> Use correct value for -moz-margin-*
> 
> Thanks for noticing that in your endless stdout stream!

Hehe, sometimes I need good bedtime reading material :-P

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

I guess the only questions that I have is that if this got checked in like this, and the 'none' value is ignored, did it need to be switched to '0' or could the lines have been deleted?

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Mike, please see comment #3.

Comment 5

[Mike de Boer [:mikedeboer]]

(In reply to Jared Wein [:jaws] from comment #4)
> Mike, please see comment #3.

Ah yes, sorry about that; I wanted to delete the lines. KISS!

Comment 6

[Mike de Boer [:mikedeboer]]

Attachment: Remove incorrect usages of -moz-margin-*

Removed unneeded margin decl.

Comment 7

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/899389c30a16