880625 - Updates to the PSL

Status: RESOLVED INCOMPLETE

(Core Graveyard :: Networking: Domain Lists, defect)

Description

[Simone Carletti]

We received several amendments from Tobias Sattler and Aaron Gable.
They need to be checked and merged.

Comment 1

[Simone Carletti]

Attachment: Patch from Tobias

Comment 2

[Simone Carletti]

Attachment: Patch from Aaron

Comment 3

[Gervase Markham [:gerv]]

weppos: do you need to do more here? If not, please set a review flag for me.

Gerv

Comment 4

[Simone Carletti]

Yes, I actually still need to validate these changes. I posted the patches here as a reminder.

Comment 5

[Simone Carletti]

Attachment: 880625.patch

First batch, TLDs from A-C.

Whenever possible, I validated the list using the registry information. Otherwise, Wikipedia.

Comment 6

[Gervase Markham [:gerv]]

Did Tobias and Aaron not specify their sources? Are they just two members of the public, or do they have special knowledge in some way? I notice in some cases they suggest different changes for the same TLD, so it would be useful to understand where they got the info from. One may have a better source than the other.

Gerv

Comment 7

[Simone Carletti]

No, they didn't specify the sources. You may be able to find their email and domains in your email archive. Aaron is from Google, Tobias from United Domains.

I'm not sure why they ended up with such differences. So far, their proposal were quite similar.

I'm going to each TLD one by one, that's why it's taking time.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a8808a02a661

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(In reply to Ryan VanderMeulen [:RyanVM UTC-5][Back 2-Dec] from comment #8)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/a8808a02a661

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/c6f465d6cfb0 for causing a test failure:
https://tbpl.mozilla.org/php/getParsedLog.php?id=31118852&tree=Mozilla-Inbound

Comment 10

[Gervase Markham [:gerv]]

See bug 943800 for my plan to prevent this happening in future.

In the mean time, weppos: can you also produce an update to the PSL test suite file?

Gerv

Comment 11

[Simone Carletti]

Attachment: 880625-AC.patch

Here's the new patch that includes the changes to the PSL and test suite.

Comment 12

[Gervase Markham [:gerv]]

Comment on attachment 8339281 [details] [diff] [review]
880625-AC.patch

r=gerv.

Gerv

Comment 13

[Simone Carletti]

@Ryan

The patch I provided was the first step (TLDs from A to C). The attachment you flagged as obsolete are still under review.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/13c1b3a2d135

Not sure if this is supposed to be [leave open] or not. Please add it to the whiteboard if there's more work to be done here.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Backed out for xpcshell failures (again). Please run this through Try before requesting checkin again.
https://hg.mozilla.org/integration/mozilla-inbound/rev/e5ca4a98aa68

https://tbpl.mozilla.org/php/getParsedLog.php?id=31324689&tree=Mozilla-Inbound

Comment 16

[Simone Carletti]

I didn't notice .ck was also in use in the test. The previous time it failed before and never reported it.

@Ryan, Gerv
Is there any way for me to run that single spec suite locally on my machine without running all specs?

Comment 17

[Gervase Markham [:gerv]]

> I didn't notice .ck was also in use in the test.

This is why it would be useful to have a big comment before the .ck block which said "This is used in tests" :-)

You can run a single test. But you need to build your own copy of Firefox first.

Then:
./mach xpcshell-test netwerk/test/unit/test_psl.js

Gerv

Comment 18

[Simone Carletti]

@gerv

I propose to close this ticket, as we made several changes in the PSL since then and the list now is at https://github.com/publicsuffix/list

I'm quite sure that if any of the proposed changes are still valid in the new PSL, we'll discover them soon (given also the recent adoption by LE).

Do you agree?

Comment 19

[Gervase Markham [:gerv]]

OK.

Gerv