880626 - [TrustedUI] Send an error key instead of a localized string if the user closes the trusted dialog.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Fernando Jiménez Moreno [:ferjm]]

See Bug 879579

Comment 1

[Fernando Jiménez Moreno [:ferjm]]

Attachment: v1

I am not sure if I was supposed to remove the string from all the locale files.

Comment 2

[Fernando Jiménez Moreno [:ferjm]]

I'll be asking for approval to uplift this to v1.1 so I guess I need to add the late-l10n keyword.

Comment 3

[Axel Hecht [:Pike]]

Comment on attachment 759692 [details] [diff] [review]
v1

Review of attachment 759692 [details] [diff] [review]:
-----------------------------------------------------------------

I don't mind about the in-tree .properties files, they're not used for production builds at all.

If you're changing the semantics of what you're passing around with the cancel event, I'd change the key, too. After all, this is not the message that users are supposed to see, but some other thing.

Comment 4

[Axel Hecht [:Pike]]

Removing late-l10n keyword as we haven't established what that would mean. Also this is only removing a string.

Comment 5

[Etienne Segonzac (:etienne)]

Comment on attachment 759692 [details] [diff] [review]
v1

Review of attachment 759692 [details] [diff] [review]:
-----------------------------------------------------------------

Looking good.

Comment 6

[Fernando Jiménez Moreno [:ferjm]]

https://github.com/mozilla-b2g/gaia/commit/18614f8e4a10cb299481dbe8004f925fec4cfe74