[TrustedUI] Send an error key instead of a localized string if the user closes the trusted dialog.

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: ferjm, Assigned: ferjm)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Updated

5 years ago
Assignee: nobody → ferjmoreno
(Assignee)

Comment 1

5 years ago
Created attachment 759692 [details] [diff] [review]
v1

I am not sure if I was supposed to remove the string from all the locale files.
Attachment #759692 - Flags: review?(etienne)
Attachment #759692 - Flags: feedback?(l10n)
(Assignee)

Comment 2

5 years ago
I'll be asking for approval to uplift this to v1.1 so I guess I need to add the late-l10n keyword.
Keywords: late-l10n

Comment 3

5 years ago
Comment on attachment 759692 [details] [diff] [review]
v1

Review of attachment 759692 [details] [diff] [review]:
-----------------------------------------------------------------

I don't mind about the in-tree .properties files, they're not used for production builds at all.

If you're changing the semantics of what you're passing around with the cancel event, I'd change the key, too. After all, this is not the message that users are supposed to see, but some other thing.
Attachment #759692 - Flags: feedback?(l10n)

Comment 4

5 years ago
Removing late-l10n keyword as we haven't established what that would mean. Also this is only removing a string.
Keywords: late-l10n

Updated

5 years ago
Blocks: 846517
Comment on attachment 759692 [details] [diff] [review]
v1

Review of attachment 759692 [details] [diff] [review]:
-----------------------------------------------------------------

Looking good.
Attachment #759692 - Flags: review?(etienne) → review+
(Assignee)

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.