880670 - [email/activesync] some ActiveSync implementations blacklist Mozilla in the user-agent string and return a 440 status code; we should change our reported user agent

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Juan Perez-Bedmar [:juanpbf]]

Reported by operator during IOT
Seen on Ikura

QC RIL version:
"ro.build.firmware_revision=V1.01.00.01.019.120"
gaia commit:
50abeb2 Merge pull request #10032 from alivedise/bugzilla/872912_v1.0.1b
gecko commit:
a6a5487 Bug 875483 - YouTube HTML5 Playback hangs Firefox. r=derf,a=tef+


When configuring an Email account, if you enter a wrong user or a wrong password, the message shown is not accurate

STEPS TO REPRODUCE:
    1. Open Email app. 
    2. Add a new account. 
    3. Enter the requested fields, but enter a wrong password.
    4. Check the error message shown.

CURRENT BEHAVIOUR:
"Hay un problema con "HTTPS://mailar.telefonica,com". Pruebe de nuevo pasados unos minutos."
("There is a problem with xxxx. Try again a few minutes later")

EXPECTED BEHAVIOUR:
There should be a message specifying that you have entered a wrong password

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

Can you provide the (unlocalized) error code in brackets displayed below the error message?  Also, please describe how you are setting up the account; manual setup or automatic?  What domain do you actually enter for the account?

We explicitly map 401 errors to 'bad-user-or-pass' which has some unit-test coverage, but the autodiscover function does have unconditional failover logic to trying a second domain in the event of any http error on the first domain.  Assuming there's not a problem with the telefonica server, we are likely turning the 401 into a dns lookup failure.

Comment 2

[Juan Perez-Bedmar [:juanpbf]]

I will contact with the reporter in the operator side as it was him who reproduced the bug. 

I'll come back with the feedback ASAP

BR

Comment 3

[Juan Perez-Bedmar [:juanpbf]]

Attachment: Screenshot with the error message

This is the screenshot provided by the reporter. According to this, the error message received is 440

Comment 4

[Jim Porter (:squib)]

HTTP 440 isn't listed anywhere in the ActiveSync specs. While it's possible we're doing what comment 1 suggests, I doubt that's the issue here. Are you sure the server is configured correctly? HTTP 440 is used for Exchange (not ActiveSync, as far as I can tell), and refers to "login timeout".

Here's the best reference I could find to this: http://support.microsoft.com/kb/917686

Comment 5

[Jim Porter (:squib)]

Ok, I figured out why this is happening (or at least, I figured out one of the "whys"): c2s.fr is blocking ActiveSync connections if the User-Agent contains the string "Mozilla".

Maybe it's trying to block web browsers, since I'm pretty sure all of them have the string "Mozilla"?

Comment 6

[Xavier Laurent]

I encounter the same problem with my company's Exchange Server 2010: the OPTION request fails with HTTP 440 status.

Changing my phone user agent string (since it cannot be overridden at XMLHttpRequest level) to anything not containing "Mozilla" as described in https://wiki.mozilla.org/B2G/QA/Tips_And_Tricks#User_Agent makes ActiveSync works fine.

Comment 7

[Jim Porter (:squib)]

Attachment: Fix it in jsas [checked in]

Comment 8

[Jim Porter (:squib)]

Attachment: Update in GELAM [checked in]

Comment 9

[Jim Porter (:squib)]

Attachment: Update in Gaia

Comment 10

[Jim Porter (:squib)]

Comment on attachment 8438849 [details] [review]
Update in Gaia

I've verified that this works with a real account that was experiencing the issue, so we can land this just as soon as the tree reopens.

Comment 11

[Jim Porter (:squib)]

Landed.

Comment 12

[Andrew Sutherland [:asuth] (he/him)]

Triagers, please propagate blocking=1.3+ from bug 1020069 to enable uplift.  I will comment on that bug too.

landed in gelam/master:
https://github.com/mozilla-b2g/gaia-email-libs-and-more/pull/311
https://github.com/mozilla-b2g/gaia-email-libs-and-more/commit/348acf89bdd09b67cd505d5cd8c4799e91baa316

landed in gaia/master:
https://github.com/mozilla-b2g/gaia/pull/20397
https://github.com/mozilla-b2g/gaia/commit/43a4e7f3710d727c4aa9581f48318456d627a399

Comment 13

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 8438849 [details] [review]
Update in Gaia

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Has always existed; a problem with ActiveSync servers that sniff the user-agent to decide whether they're talking to an ActiveSync client or a web browser.
[User impact] if declined: Bug 1020069, a 1.3 cert-blocker cannot be uplifted/fixed, people get sad.
[Testing completed]: :squib tested.
[Risk to taking this patch] (and alternatives if risky):  Risk is considered low, but the fundamental risk would be that there is some type of other user-agent sniffing going on out there where ActiveSync servers really want to see "Mozilla" or something like that in the user-agent.  This is deemed unlikely because no ActiveSync clients out there are believed to do this.  Waiting is unlikely to help us gain additional confidence about this.
[String changes made]: No l10n-related strings were touched.

Comment 14

[Dylan Oliver [:doliver]]

Blocking a 1.3 blocker, clearing for uplift.

Comment 15

[Xavier Laurent]

Thanks for that quick fix!
This means that contrarily to what is told in bug 627942 it is now allowed to override user agent on XMLHttpRequest. Is this allowed for privileged apps / extensions only? Is this behavior documented somewhere?

Comment 16

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/8716ad7a698a511cd9d80e878438dc93658ef122
v1.4: https://github.com/mozilla-b2g/gaia/commit/01086cb4f03ebe5b1a976519edd183660d296aa3

Comment 17

[Ryan VanderMeulen [:RyanVM]]

v1.3: https://github.com/mozilla-b2g/gaia/commit/5f4211ac94cc158a07269d0a0beca3c7937d78cc

Comment 18

[Paladin]

Attachment: Verify_image.png

This issue has been verified successfully on Flame 2.0,2.1

See attachment: Verify_image.png
Reproducing rate: 0/5
Flame 2.1 build:
Gaia-Rev        db2e84860f5a7cc334464618c6ea9e92ff82e9dd
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/211eae88f119
Build-ID        20141126001202
Version         34.0
FLame 2.0 build:
Gaia-Rev        f9d6e3d83c3922e9399a6c27f5ce4cdd27bdfd05
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/45112935086f
Build-ID        20141126000203
Version         32.0