88081 - Focus doesn't work properly in the ActiveX control

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: ActiveX Wrapper, defect)

Description

[Adam Lock]

The activex control doesn't allow form fields to be selected or typed into.

Comment 1

[Adam Lock]

*** Bug 88141 has been marked as a duplicate of this bug. ***

Comment 2

[Adam Lock]

Dave, if I add an Activate after creation will that be sufficient for making
focus work? The control is embedded in someone else's window so it won't know
when it's parent frame (if there is one) has been activated or deactivated.

Comment 3

[saari (gone)]

Yes, an embeddor wants to notify the embedded Gecko of activates and deactives,
otherwise the focus controller will lock down commands, selection, typing, etc.

I'm not 100% certain that is the problem here, but it definitely what you should
try first.

Comment 4

[Adam Lock]

I'll add some activation code to initialisation.

One thing I won't be able to do is know when the host frame is
activated/deactivated because it belongs to the client and they won't bother to
notify me.

Comment 5

[saari (gone)]

then selections won't grey out for an inactive window, among other things.

Comment 6

[Harshal Pradhan]

This bug makes the activex control pretty unusable for forms. 

I am having to use a much older version of mozilla for my app because this has 
been broken for some time now. Any idea on when this might get fixed?

Comment 7

[Adam Lock]

Attachment: Focus fix for the control

Comment 8

[Adam Lock]

Chris, can you review the patch please? It fixes the gross deficiencies in the 
control so focus, tabbing and keyboard more or less work correctly.

I still haven't put in a proper implementation of nsIWebBrowserChromeFocus so 
tabbing out of the control might not work but everything else appears to 
function. Bug 101571 covers a problem I discovered with tabbing when embedding 
Gecko in a dialog box.

Comment 9

[saari (gone)]

Comment on attachment 50735 [details] [diff] [review]
Focus fix for the control

Looks like the right thing, r=saari

Comment 10

[Adam Lock]

Attachment: Slightly updated version implements nsIWebBrowserFocus properly, submitting for sr

Comment 11

[rpotts (gone)]

Comment on attachment 50888 [details] [diff] [review]
Slightly updated version implements nsIWebBrowserFocus properly, submitting for sr

sr=[e-mail]

looks good to me...

Comment 12

[Adam Lock]

Fix is checked in. Bug 101571 will still have to be sorted out before the
control will work well in dialog boxes.

Comment 13

[Richard Clippard]

There still seems to be a problem when included in an ActiveX control in a dialog. I have downloaded the build for Oct 9, 2001 and the problem still exists (sample available).

CAxWindow *browserControlWindow = new CAxWindow(m_hWnd);
HRESULT hResult = browserControlWindow->CreateControl(L"Mozilla.Browser.1");
CComQIPtr<IWebBrowser2, &IID_IWebBrowser2> pWebBrowser;
browserControlWindow->QueryControl(IID_IWebBrowser2, reinterpret_cast<void**>(&pWebBrowser));
pWebBrowser->Navigate(T"test.html",0,0,0,0);