880868 - Browser Console JS Error/Warning filtering doesn't seem to work

Status: RESOLVED FIXED

(DevTools :: Console, defect, P3)

Description

[:Gavin Sharp [email: [e-mail]]]

STR:
1) run ./mach mochitest-browser --keep-open browser/components/search/test/browser_private_search_perwindowpb.js
2) when done, switch to the browser window, open the browser console and the error console
3) in the error console, select "Errors", and in the Browser Console, unselect all the buttons except "JS", and then in the JS button dropdown uncheck "Warnings"

Expected results:
- See the same output in both consoles (in this case, no errors)

Actual results:
- Browser Console continues to show a bunch of non-error messages (screenshot: http://cl.ly/image/353E2l352J3m)

Comment 1

[Mihai Sucan [:msucan]]

This happens because the remaining messages are nsIConsoleMessages (not nsIScriptErrors) and they have the "log" severity associated - in contrast with the "warning" and "error" severities.

We need to add the "log" severity to that JavaScript category (the drop down menu).

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Or maybe fix the message types? The old Error Console treated them as "Errors"...

Comment 3

[Mihai Sucan [:msucan]]

Attachment: proposed patch

This patch adds the "log" option to the JS category drop-down in the Browser Console.

Comment 4

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 764924 [details] [diff] [review]
proposed patch

Review of attachment 764924 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm.

Comment 5

[Mihai Sucan [:msucan]]

https://hg.mozilla.org/integration/fx-team/rev/75c01c222ab6

Comment 6

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/mozilla-central/rev/75c01c222ab6