Closed Bug 880868 Opened 7 years ago Closed 7 years ago

Browser Console JS Error/Warning filtering doesn't seem to work

Categories

(DevTools :: Console, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 24

People

(Reporter: Gavin, Assigned: msucan)

References

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(1 file)

STR:
1) run ./mach mochitest-browser --keep-open browser/components/search/test/browser_private_search_perwindowpb.js
2) when done, switch to the browser window, open the browser console and the error console
3) in the error console, select "Errors", and in the Browser Console, unselect all the buttons except "JS", and then in the JS button dropdown uncheck "Warnings"

Expected results:
- See the same output in both consoles (in this case, no errors)

Actual results:
- Browser Console continues to show a bunch of non-error messages (screenshot: http://cl.ly/image/353E2l352J3m)
This happens because the remaining messages are nsIConsoleMessages (not nsIScriptErrors) and they have the "log" severity associated - in contrast with the "warning" and "error" severities.

We need to add the "log" severity to that JavaScript category (the drop down menu).
Priority: -- → P3
Or maybe fix the message types? The old Error Console treated them as "Errors"...
Attached patch proposed patchSplinter Review
This patch adds the "log" option to the JS category drop-down in the Browser Console.
Assignee: nobody → mihai.sucan
Status: NEW → ASSIGNED
Attachment #764924 - Flags: review?(rcampbell)
Depends on: 884887
Blocks: 878186
Comment on attachment 764924 [details] [diff] [review]
proposed patch

Review of attachment 764924 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm.
Attachment #764924 - Flags: review?(rcampbell) → review+
https://hg.mozilla.org/mozilla-central/rev/75c01c222ab6
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 24
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.