Roll out talos mozharness on Cedar

RESOLVED FIXED

Status

Release Engineering
Mozharness
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: jyeo, Assigned: jyeo)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 2 obsolete attachments)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Created attachment 759985 [details] [diff] [review]
add mozharness repo and enable mozharness

This should be all that we need to do to enable mozharness on Cedar right?
Attachment #759985 - Flags: review?(armenzg)
(Assignee)

Updated

5 years ago
Assignee: nobody → yshun
Comment on attachment 759985 [details] [diff] [review]
add mozharness repo and enable mozharness

We shouldn't point to a different mozharness repo.

If you patches are ready to land to the official mozharness repo, it's time to do so.
I believe you can already do so. Please use this format when pushing to the official mozharness repo: "Bug XXXXXX - summary of the bug. r=nickname_of_reviewer"

The changes will only be live when the changes on the default branch will merge to the production branch.
Attachment #759985 - Flags: review?(armenzg) → review-
(Assignee)

Comment 3

5 years ago
Created attachment 760373 [details] [diff] [review]
Enable talos mozharness on Cedar

Once this is enabled, I should be merging the patches from ash-mozharness into build/mozharness right?
Attachment #759985 - Attachment is obsolete: true
Attachment #760373 - Flags: review?(armenzg)
Comment on attachment 760373 [details] [diff] [review]
Enable talos mozharness on Cedar

Review of attachment 760373 [details] [diff] [review]:
-----------------------------------------------------------------

General FYI, you can check what differences your patches produces by outputting the configuration files.

See https://wiki.mozilla.org/ReleaseEngineering:TestingTechniques#config.py_is_executable.21 for more info.

With regards the patch, see the comment below and the conditional r+. Feel free to land.

::: mozilla/project_branches.py
@@ +232,5 @@
>          },
>      },
>      'cedar': {
> +        'mozharness_repo_path': 'build/mozharness',
> +        'mozharness_repo': 'http://hg.mozilla.org/build/mozharness',

No need to add it here; it is a default implicit value.
On Ash, we use something different than the default.

You get r+ on the condition of removing this 2 lines.
Attachment #760373 - Flags: review?(armenzg) → review+
(Assignee)

Comment 5

5 years ago
Created attachment 760428 [details] [diff] [review]
Enable talos mozharness on Cedar

Since I don't have commit access, I shall attach the patch here.
Attachment #760373 - Attachment is obsolete: true
Attachment #760428 - Flags: review?(armenzg)
Would talos on Cedar work if we're pointing to test datazilla credentials?
    1.12 +    "datazilla_urls": ["https://datazilla.mozilla.org/test"],
    1.13 +    "datazilla_authfile": "http://people.mozilla.com/~yshun/slaves.txt",

I think we're fine but I wanted to check with you first.
Flags: needinfo?(aki)

Comment 7

5 years ago
a) Does it work on ash?
b) I'm not that familiar with datazilla or how talos works with it.  The ateam may be able to clarify.
Flags: needinfo?(aki)
(In reply to Aki Sasaki [:aki] from comment #7)
> a) Does it work on ash?
> b) I'm not that familiar with datazilla or how talos works with it.  The
> ateam may be able to clarify.

jyeo, do you mind finding an answer to this? Thanks!
The day that we enable this across the board. We will need a patch for mozilla-inbound for the newer talos.json format.
Perhaps we can land it in advance.

Comment 10

5 years ago
As long as we don't touch the talos zip portion, we can roll out the rest in advance.
(Assignee)

Comment 11

5 years ago
Created attachment 770780 [details] [diff] [review]
Add revision string, new talos version and xperf test suite to talos json
Attachment #770780 - Flags: review?(aki)

Updated

5 years ago
Attachment #770780 - Flags: review?(aki) → review+
Attachment #760428 - Flags: review?(armenzg) → review+
in production
(Assignee)

Comment 13

5 years ago
Created attachment 772107 [details] [diff] [review]
use hg instead of hgtool
Attachment #772107 - Flags: review?(aki)
(Assignee)

Comment 14

5 years ago
I should have diff'ed the mozharness version of talos.py with ash-mozharness version earlier on. My bad.

Updated

5 years ago
Attachment #772107 - Flags: review?(aki) → review+
(Assignee)

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Comment on attachment 772107 [details] [diff] [review]
use hg instead of hgtool

in production
Product: mozilla.org → Release Engineering

Updated

4 years ago
Component: General Automation → Mozharness
You need to log in before you can comment on or make changes to this bug.