Closed Bug 881014 Opened 11 years ago Closed 11 years ago

Cancel buttons in UI should call RP's oncancel method

Categories

(Core Graveyard :: Identity, defect)

Product:
Core Graveyard
Component:
Identity
Version:
22 Branch
Platform:
All
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:leo+, firefox22 wontfix, firefox23 wontfix, firefox24 fixed, b2g18 fixed, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 wontfix, b2g-v1.1hd fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla24
Project Flags:
blocking-b2g leo+
Tracking Flags:
Tracking Status
firefox22 --- wontfix
firefox23 --- wontfix
firefox24 --- fixed
b2g18 --- fixed
b2g18-v1.0.0 --- wontfix
b2g18-v1.0.1 --- wontfix
b2g-v1.1hd --- fixed

People

(Reporter: jedp, Assigned: ozten)

References

Details

Attachments

(1 file)

Proposed fix for adding oncancel callback
918 bytes, patch
jedp
: review+
Details | Diff | Splinter Review
Some Cancel buttons were added to the Persona dialog for mobile. These currently return success with a null assertion. They should call the RP's oncancel handler.
Assignee: nobody → ozten.bugs
blocking-b2g: --- → leo?
The assertion is null, when we cancel via the "Cancel" button. There are no other cases where we get an assertion equal to null, that can't be interpreted as a cancel, AFAIK.
Attachment #760144 - Flags: review?(jparsons)
Comment on attachment 760144 [details] [diff] [review] Proposed fix for adding oncancel callback Review of attachment 760144 [details] [diff] [review]: ----------------------------------------------------------------- Looks great, Austin. I've verified with the UI Tests -> navigator.mozId tests For QA reference, can test as follows: 1. click Request with oncancel handler 2. click cancel button in UI 3. trusted UI closes 4. event stream shows 'cancel' yay!
Attachment #760144 - Flags: review?(jparsons) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/1db48d05d302
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
Extra Info for leo?: Getting a cancel callback will make websites that use the older "get" API work properly. This is a high percentage of websites. The UX won't be as good without a cancel callback.
Linking to PayId tracking bug
Blocks: PayId-v1next
Blocks: 881962
blocking-b2g: leo? → leo+
Note for MozTrap test case - just use the STR provided in bug 881962.
Flags: in-moztrap?
Flags: in-moztrap? → in-moztrap-
Please read comment 10.
Flags: in-moztrap- → in-moztrap?
Flags: in-moztrap?
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: