If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Cancel buttons in UI should call RP's oncancel method

RESOLVED FIXED in Firefox 24, Firefox OS v1.1hd

Status

()

Core
Identity
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jedp, Assigned: ozten)

Tracking

(Blocks: 1 bug)

22 Branch
mozilla24
All
Gonk (Firefox OS)
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(blocking-b2g:leo+, firefox22 wontfix, firefox23 wontfix, firefox24 fixed, b2g18 fixed, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 wontfix, b2g-v1.1hd fixed)

Details

Attachments

(1 attachment)

Some Cancel buttons were added to the Persona dialog for mobile.  These currently return success with a null assertion.  They should call the RP's oncancel handler.
Assignee: nobody → ozten.bugs
blocking-b2g: --- → leo?
(Assignee)

Comment 1

4 years ago
Created attachment 760144 [details] [diff] [review]
Proposed fix for adding oncancel callback

The assertion is null, when we cancel via the "Cancel" button. There are no other cases where we get an assertion equal to null, that can't be interpreted as a cancel, AFAIK.
Attachment #760144 - Flags: review?(jparsons)
Comment on attachment 760144 [details] [diff] [review]
Proposed fix for adding oncancel callback

Review of attachment 760144 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great, Austin.

I've verified with the UI Tests -> navigator.mozId tests

For QA reference, can test as follows:
1. click Request with oncancel handler
2. click cancel button in UI
3. trusted UI closes
4. event stream shows 'cancel' yay!
Attachment #760144 - Flags: review?(jparsons) → review+
(Assignee)

Comment 3

4 years ago
https://tbpl.mozilla.org/?tree=Try&rev=420844c7a163
(Assignee)

Comment 4

4 years ago
https://tbpl.mozilla.org/?tree=Try&rev=1ecfa73dcd88
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/projects/birch/rev/1db48d05d302
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/1db48d05d302
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
(Assignee)

Comment 7

4 years ago
Extra Info for leo?:
Getting a cancel callback will make websites that use the older "get" API work properly. This is a high percentage of websites. The UX won't be as good without a cancel callback.
Linking to PayId tracking bug
Blocks: 846517
Blocks: 881167

Updated

4 years ago
Blocks: 881962

Updated

4 years ago
blocking-b2g: leo? → leo+
https://hg.mozilla.org/releases/mozilla-b2g18/rev/08f0dbad4be4
status-b2g18: --- → fixed
status-b2g18-v1.0.0: --- → wontfix
status-b2g18-v1.0.1: --- → wontfix
status-b2g-v1.1hd: --- → affected
status-firefox22: --- → wontfix
status-firefox23: --- → wontfix
status-firefox24: --- → fixed
Note for MozTrap test case - just use the STR provided in bug 881962.
Flags: in-moztrap?
https://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/08f0dbad4be4
status-b2g-v1.1hd: affected → fixed

Updated

4 years ago
Flags: in-moztrap? → in-moztrap-
Please read comment 10.
Flags: in-moztrap- → in-moztrap?

Updated

4 years ago
Flags: in-moztrap?
You need to log in before you can comment on or make changes to this bug.