Closed Bug 881022 Opened 10 years ago Closed 10 years ago

potential for crash in mozilla::layout::ScrollbarActivity::SetIsFading

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Version:
23 Branch
Platform:
x86_64
macOS
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla24
Tracking Flags:
Tracking Status
firefox21 --- unaffected
firefox22 --- unaffected
firefox23 + verified
firefox24 + verified
firefox-esr17 --- unaffected

People

(Reporter: spohl, Assigned: spohl)

References

Details

(Keywords: crash, regression, Whiteboard: [lion-scrollbars+])

Attachments

(1 file)

Patch
3.97 KB, patch
roc
: review+
akeybl
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
+++ This bug was initially created as a clone of Bug #877097 +++

Bug 877097 revealed that ScrollbarActivity::SetIsFading may crash in similar fashion as ScrollbarActivity::UpdateOpacity used to. A similar fix should be written for ScrollbarActivity::SetIsFading.
Attached patch Patch — — Splinter Review 

        Attachment #760151 -
        Flags: review?(roc)

    
  
Status: NEW → ASSIGNED

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/625de2ded691
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24

    
    

    
  
Comment on attachment 760151 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 636564
User impact if declined: Potential for crashes, similar to the ones reported in bug 877097.
Testing completed (on m-c, etc.): Has been on m-c for a few days.
Risk to taking this patch (and alternatives if risky): low, since the fix closely matches what was done for bug 877097.
String or IDL/UUID changes made by this patch: none

        Attachment #760151 -
        Flags: approval-mozilla-aurora?

    
  

        Attachment #760151 -
        Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

    
    

    
  
Requesting checkin for aurora.
Keywords: checkin-needed

    
    

    
  
Verified as fixed on Firefox 23 beta 8 - I could not find any crashes in Socorro with the signature:  [@ mozilla::layout::ScrollbarActivity::SetIsFading].

          status-firefox23:
          fixed → verified

    
    

    
  
(In reply to Simona B [QA] from comment #7)
> Verified as fixed on Firefox 23 beta 8 - I could not find any crashes in
> Socorro with the signature:  [@
> mozilla::layout::ScrollbarActivity::SetIsFading].
Verified FF 24b8
Status: RESOLVED → VERIFIED

          status-firefox24:
          fixed → verified

          You need to log in
          before you can comment on or make changes to this bug.