881022 - potential for crash in mozilla::layout::ScrollbarActivity::SetIsFading

Status: VERIFIED FIXED

(Core :: Layout, defect)

Description

[Stephen A Pohl [:spohl]]

+++ This bug was initially created as a clone of Bug #877097 +++

Bug 877097 revealed that ScrollbarActivity::SetIsFading may crash in similar fashion as ScrollbarActivity::UpdateOpacity used to. A similar fix should be written for ScrollbarActivity::SetIsFading.

Comment 1

[Stephen A Pohl [:spohl]]

Attachment: Patch

Comment 2

[Stephen A Pohl [:spohl]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/625de2ded691

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/625de2ded691

Comment 4

[Stephen A Pohl [:spohl]]

Comment on attachment 760151 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 636564
User impact if declined: Potential for crashes, similar to the ones reported in bug 877097.
Testing completed (on m-c, etc.): Has been on m-c for a few days.
Risk to taking this patch (and alternatives if risky): low, since the fix closely matches what was done for bug 877097.
String or IDL/UUID changes made by this patch: none

Comment 5

[Stephen A Pohl [:spohl]]

Requesting checkin for aurora.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/98321750ea22

Comment 7

[Simona Badau, Desktop QA]

Verified as fixed on Firefox 23 beta 8 - I could not find any crashes in Socorro with the signature:  [@ mozilla::layout::ScrollbarActivity::SetIsFading].

Comment 8

[Paul Silaghi, QA [:pauly]]

(In reply to Simona B [QA] from comment #7)
> Verified as fixed on Firefox 23 beta 8 - I could not find any crashes in
> Socorro with the signature:  [@
> mozilla::layout::ScrollbarActivity::SetIsFading].
Verified FF 24b8