Closed
Bug 881127
Opened 12 years ago
Closed 12 years ago
GAIA_DEV_PIXELS_PER_PX param for Gaia build script
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(blocking-b2g:hd+, b2g18 fixed, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 wontfix, b2g-v1.1hd fixed)
VERIFIED
FIXED
| blocking-b2g | hd+ |
People
(Reporter: timdream, Assigned: yurenju)
References
Details
Attachments
(1 file)
We now have HIDPI support on master branch. HIDPI switch replace @1x images with @2x ones when turned on. Since the target device comes with device-pixel-ratio=1.5, we would need be able to specify the ratio explicitly; hence, we will upgrade the HIDPI param to GAIA_DEV_PIXELS_PER_PX.
(The related Gecko pref is layout.css.devPixelsPerPx, hence the name)
As HIDPI support never landed on v1-train, I expect the patch for both branches on this bug will be different.
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → yurenju.mozilla
|
Reporter | |
Updated•12 years ago
|
status-b2g18:
--- → wontfix
status-b2g18-v1.0.0:
--- → wontfix
status-b2g18-v1.0.1:
--- → wontfix
status-b2g-v1.1hd:
--- → affected
|
|
Assignee | |
Comment 2•12 years ago
|
||
Pointer to Github pull-request
|
|
Assignee | |
Comment 3•12 years ago
|
||
Comment on attachment 764638 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10479
><!DOCTYPE html><meta charset="utf-8"><meta http-equiv="refresh" content="5;https://github.com/mozilla-b2g/gaia/pull/10479"><title>Bugzilla Code Review</title><p>You can review this patch at <a href="https://github.com/mozilla-b2g/gaia/pull/10479">https://github.com/mozilla-b2g/gaia/pull/10479</a>, or wait 5 seconds to be redirected there automatically.</p>
Attachment #764638 -
Attachment description: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10479/files → Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10479
Attachment #764638 -
Flags: review?(timdream)
Attachment #764638 -
Flags: feedback?(rexboy)
|
|
Reporter | |
Comment 4•12 years ago
|
||
Comment on attachment 764638 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10479
\O/
Attachment #764638 -
Flags: review?(timdream) → review+
|
||
Comment 5•12 years ago
|
||
Comment on attachment 764638 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10479
Looks good, debug mode also works well.
Thank you!
Attachment #764638 -
Flags: feedback?(rexboy) → feedback+
|
|
Assignee | |
Comment 6•12 years ago
|
||
Merged.
master:
https://github.com/mozilla-b2g/gaia/commit/02099ce2552d806660cbe80ff941ef77578e35f3
v1.1.0hd:
https://github.com/mozilla-b2g/gaia/commit/df7488db5d1fb8b841246d4d04c7c685d44367ce
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Comment 7•12 years ago
|
||
This commit appears to be causing failures on desktop builds -
https://tbpl.mozilla.org/php/getParsedLog.php?id=24393384&tree=Mozilla-Inbound&full=1#error0
See https://tbpl.mozilla.org/?tree=Mozilla-Inbound&showall=1 for more failures.
|
||
Comment 8•12 years ago
|
||
I don't even pretend to understand how, but the desktop build problem was coming from mozilla-central and mozilla-inbound using the gaia rev *before* this, but... um... something else, I don't know what, referring to GAIA_DEV_PIXELS_PER_PX. Once m-c and m-i got a merge that started them building on a later gaia rev, they were fine.
|
|
Reporter | |
Updated•12 years ago
|
|
||
Comment 9•12 years ago
|
||
v1.1.0hd: df7488db5d1fb8b841246d4d04c7c685d44367ce
v1.1.0hd: 88a5c65cbd5b1e77b81b7e0cdcfc113da7ff43e6
|
||
Comment 10•12 years ago
|
||
v1.1.0hd: df7488db5d1fb8b841246d4d04c7c685d44367ce
v1.1.0hd: 88a5c65cbd5b1e77b81b7e0cdcfc113da7ff43e6
|
||
Updated•11 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•