881136 - hdpi/xhdpi resolution assets and layout for Browser app

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

This bug represents fixes needed in Browser app in order to deliver bug 881126:

-- Have visual supply us with @1.5x and the correct @2x images.
-- On v1.1hd, modify CSS/JS so that apps will display @1.5x/@2x images correctly.
-- On master, drop the @1.5x and @2x images and make sure there is no
more to tweak besides changes made on bug 830644.

As HIDPI support never landed on v1-train, I expect the patch for both
branches on this bug will be different. The CSS/JS patch on v1.1hd will be based on the patch on master, but I won't expect it to be as simple as a |git cherry-pick|; so this is
where the engineering work lays.

The patch on top of v1-train should land on v1.1hd.

Comment 1

[Wayne Chang [:wchang]]

Setting hd+ for 1.1hd specific requirement

Comment 2

[[e-mail]]

Attachment: pull request redirect to github

WIP without HD image

Comment 3

[[e-mail]]

add mock HD image in PR and rebased

Comment 4

[[e-mail]]

Comment on attachment 765245 [details]
pull request redirect to github

This bug aims to achieve similar goal with bug 830644 on hd1.1.0 branch.
Since we need some specified step to try on WVGA device (partial can be tested
on Nightly), if you care about the changes and would like to do a full review,
you may set review flag after reviewing; otherwise, you may set feedback flag
and let me find an appropriate reviewer in Taipei to review and confirm on WVGA
device.
These 1.5x assets in patch are here temporarily for confirming we're making right
layout changes, and will be replaced later after visual team supplying newly made
1.5x assets.
The step for testing by HD is noted in Github comment. Thanks a lot!

Comment 5

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 765245 [details]
pull request redirect to github

Some background-size missed, see Github.
Other parts seems good to me. I can give r+ after they are added.
Thank you!

Comment 6

[[e-mail]]

Comment on attachment 765245 [details]
pull request redirect to github

thanks for review, add required background-sizes.

I keep the new commit separated for review.
will squash before merge if this works fine.

Comment 7

[[e-mail]]

needinfo? UX,

we found origin bookmarked.png is 22x23, which is not align any other images size (might be 30x30). Is it intended for? or could you provide updated image for us to have more precise styling. 

thanks

Comment 8

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 765245 [details]
pull request redirect to github

r=me with some comments on Github.
Great work, thank you!

Comment 9

[[e-mail]]

thanks I've remove redundant style and squashed for further review

Comment 10

[[e-mail]]

Attachment: PR for master

1.5x images from v1.1.0hd for Master branch

Comment 11

[Stephany Wilkes]

Assigning the needinfo to Patryk who is overseeing HD+.

Comment 12

[Patryk Adamczyk [:patryk] UX]

Amy will attach the graphics to the bug.

Comment 13

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 765245 [details]
pull request redirect to github

Dale, could you help review the change in place of Ben?

Comment 14

[Dale Harvey (:daleharvey)]

Comment on attachment 771145 [details]
PR for master

This breaks the current layout, attaching screenshot

Comment 15

[Dale Harvey (:daleharvey)]

Attachment: Broken master screenshot

Comment 16

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Fred, would you be able to come up with a new patch tomorrow? If not we would need to ask someone else to do it...

Comment 17

[[e-mail]]

Comment on attachment 771145 [details]
PR for master

Thanks dale,

The interesting thing is if 'background-size' is assigned to resize logo(in master), the background linear-gradient is restricted to that background-size.

fixed and update the master/hd PR

Comment 18

[Amy Lee [:amylee] UX]

Attachment: 45x45 bookmark.png icon

The 22x23 icon is unscaled. I'm not sure why it's that size since I didn't work on it. The scaled @1.5 bookmark icon is 45x45 (see attached).

Comment 19

[[e-mail]]

Thanks Amy, 

update assets and make PR squashed

Comment 20

[Dale Harvey (:daleharvey)]

Comment on attachment 771145 [details]
PR for master

Cleared the new r? and r+'d the original, all looks good now, thanks

Comment 21

[Dale Harvey (:daleharvey)]

Comment on attachment 765245 [details]
pull request redirect to github

Looks good here

Comment 22

[Tim Guan-tin Chien [:timdream] (please needinfo)]

v1.1hd: https://github.com/mozilla-b2g/gaia/commit/b1c55dbf776010b62a95887c2f2d3c9072b4c04a
master: https://github.com/mozilla-b2g/gaia/commit/8a7caf98bc0bfa44babaa9f6daf40fc4f3c7db9a

Thanks all!

Comment 23

[Al Tsai [:atsai]]

[2013/10/21 Helix Testing]
Gaia:     c829a2042594b6c3a4899ee27979799a0f301534
Gecko:    http://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/f7c657f6d019
BuildID   20131015042201
Version   18.0