Closed
Bug 881141
Opened 11 years ago
Closed 11 years ago
hdpi/xhdpi resolution assets and layout for Usage app
Categories
(Firefox OS Graveyard :: Gaia::Cost Control, defect)
Tracking
(blocking-b2g:hd+, b2g-v1.1hd fixed)
People
(Reporter: timdream, Assigned: gasolin)
References
Details
Attachments
(2 files)
This bug represents fixes needed in Usage app in order to deliver bug 881126: -- Have visual supply us with @1.5x and the correct @2x images. -- On v1.1hd, modify CSS/JS so that apps will display @1.5x/@2x images correctly. -- On master, drop the @1.5x and @2x images and make sure there is no more to tweak besides changes made on bug 830644. As HIDPI support never landed on v1-train, I expect the patch for both branches on this bug will be different. The CSS/JS patch on v1.1hd will be based on the patch on master, but I won't expect it to be as simple as a |git cherry-pick|; so this is where the engineering work lays. The patch on top of v1-train should land on v1.1hd.
Assignee | ||
Comment 3•11 years ago
|
||
This bug aims to achieve similar goal with bug 830644 on hd1.1.0 branch. Since we need some specified step to try on WVGA device (partial can be tested on Nightly), if you care about the changes and would like to do a full review, you may set review flag after reviewing; otherwise, you may set feedback flag and let me find an appropriate reviewer in Taipei to review and confirm on WVGA device. These 1.5x assets in patch are here temporarily for confirming we're making right layout changes, and will be replaced later after visual team supplying newly made 1.5x assets. The step for testing by HD is noted in Github comment. Thanks a lot!
Attachment #770028 -
Flags: review?(salva)
Attachment #770028 -
Flags: review?(rexboy)
Comment 4•11 years ago
|
||
Comment on attachment 770028 [details]
pull request redirect to github
Thanks for your patch!
Well, Mostly looks good to me. But we may need to discuss on the usage graph. It looks blurry on WVGA now because the underlying canvas is sized in CSS pixel rather than device pixel. This wasn't a problem before applying device-pixel-ratio, but now we need to handle it for higher quality graphs on canvas.
We may need to set width / height of canvas using dimension of device pixel, then shrink it by CSS pixel dimension.
(For example, for WVGA, set width of canvas to 480 then shrink it to 320 using style.width).
Not sure if this is a heavy work.. If yes we can open another bug for it if we can't catch up in this week.
Comment 5•11 years ago
|
||
As KM Lee said, all looks OK but I'm worried about the change in data usage. I'm asking for a HD device in order to try, give you additional information and finally the r+. Sorry for the delay.
Assignee | ||
Comment 6•11 years ago
|
||
1.5x image from v1.1.0hd to master
Attachment #771147 -
Flags: review?(salva)
Comment 7•11 years ago
|
||
Comment on attachment 771147 [details]
PR for master
Seems perfect to me despite I have not tried in an HD device. At least, it does not crash anything in the no-HD device.
Thank you.
Attachment #771147 -
Flags: review?(salva) → review+
Comment 8•11 years ago
|
||
I'm not able to try with a WVGA resolution. Please, ask another to review this patch.
Updated•11 years ago
|
Attachment #770028 -
Flags: review?(salva)
Comment 9•11 years ago
|
||
Comment on attachment 770028 [details]
pull request redirect to github
Looks good. r=me
Thank you for helping this bug!
We still need to open a follow-up bug for lacked assets and canvas issue.
Attachment #770028 -
Flags: review?(rexboy) → review+
Assignee | ||
Comment 10•11 years ago
|
||
merged in gaia-master d899d78804e16445b696eea7649bd7090a57e40e 1.1hd 1aa86e882406ab49722dfad8ef3fe83963be6b73 thanks!
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 11•11 years ago
|
||
add followup bug 891277 for lacked assets and canvas issue
Reporter | ||
Updated•11 years ago
|
status-b2g-v1.1hd:
--- → fixed
Updated•11 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•