881148 - hdpi/xhdpi resolution assets and layout for Gallery app

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Gallery, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

This bug represents fixes needed in Gallery app in order to deliver bug 881126:

-- Have visual supply us with @1.5x and the correct @2x images.
-- On v1.1hd, modify CSS/JS so that apps will display @1.5x/@2x images correctly.
-- On master, drop the @1.5x and @2x images and make sure there is no
more to tweak besides changes made on bug 830644.

As HIDPI support never landed on v1-train, I expect the patch for both
branches on this bug will be different. The CSS/JS patch on v1.1hd will be based on the patch on master, but I won't expect it to be as simple as a |git cherry-pick|; so this is
where the engineering work lays.

The patch on top of v1-train should land on v1.1hd.

Comment 1

[Wayne Chang [:wchang]]

Setting hd+ for 1.1hd specific requirement

Comment 2

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to hd https://github.com/mozilla-b2g/gaia/pull/10599

progressbar / gradient / pattern have no x1.5 image

Comment 3

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 767100 [details]
PR to hd https://github.com/mozilla-b2g/gaia/pull/10599

Please kindly help to review it. It's for WVGA device on v1.1.0hd branch.

Comment 4

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 767100 [details]
PR to hd https://github.com/mozilla-b2g/gaia/pull/10599

Thanks for your patch, but some modification is needed. See comments on Github.

Comment 5

[Dale Harvey (:daleharvey)]

Comment on attachment 767100 [details]
PR to hd https://github.com/mozilla-b2g/gaia/pull/10599

Passing along to David for gallery review

Comment 6

[David Flanagan [:djf]]

I'll be on vacation until July 19th and do not have time to review this patch before I go.  rexboy's review seems thorough and may well be sufficient to land when he gives r+.

If you need another review, consider asking :samjoch who has recently worked on gallery CSS.

Comment 7

[David Flanagan [:djf]]

Comment on attachment 767100 [details]
PR to hd https://github.com/mozilla-b2g/gaia/pull/10599

Clearing the r? request because I won't have time to review before vacation.

Comment 8

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 767100 [details]
PR to hd https://github.com/mozilla-b2g/gaia/pull/10599

Hi Rex,

Thanks for reviewing. I just updated based on your comments. I use headers.css from bug 885228 (PR10720) to test my layout.  Please kindly check again.

Comment 9

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 767100 [details]
PR to hd https://github.com/mozilla-b2g/gaia/pull/10599

r=me.
thanks for the patch!

Comment 10

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master, x1.5 images upload

Master branch works fine in GAIA_DEV_PIXELS_PER_PX=1.5 , so I only update necessary x1.5 images.

Comment 11

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 771144 [details]
PR to master, x1.5 images upload

I think committing png files is just enough for master.
Please remove css changes and go around to see if there are any layout broken.
Thank you!

Comment 12

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 771144 [details]
PR to master, x1.5 images upload

r=me. Thanks a lot!

Comment 13

[Tim Guan-tin Chien [:timdream] (please needinfo)]

master: https://github.com/mozilla-b2g/gaia/commit/02b247112bfe9984c4f1ed086a790c8ac5a96cff
v1.1hd: https://github.com/mozilla-b2g/gaia/commit/c2987b69a075958821bf268f25630c2d00a1cfc7

Please paste the merge commits URL when closing the bug!

Comment 14

[Al Tsai [:atsai]]

[2013/10/21 Helix Testing]
Gaia:     c829a2042594b6c3a4899ee27979799a0f301534
Gecko:    http://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/f7c657f6d019
BuildID   20131015042201
Version   18.0