881158 - hdpi/xhdpi resolution assets and layout for Video app

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Video, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

This bug represents fixes needed in Video app in order to deliver bug 881126:

-- Have visual supply us with @1.5x and the correct @2x images.
-- On v1.1hd, modify CSS/JS so that apps will display @1.5x/@2x images correctly.
-- On master, drop the @1.5x and @2x images and make sure there is no
more to tweak besides changes made on bug 830644.

As HIDPI support never landed on v1-train, I expect the patch for both
branches on this bug will be different. The CSS/JS patch on v1.1hd will be based on the patch on master, but I won't expect it to be as simple as a |git cherry-pick|; so this is
where the engineering work lays.

The patch on top of v1-train should land on v1.1hd.

Comment 1

[Wayne Chang [:wchang]]

Setting hd+ for 1.1hd specific requirement

Comment 2

[John Hu [:johnhu][:johu][:醬糊小弟]]

Attachment: patch for this bug

This bug aims to achieve similar goal with bug 830644 on hd1.1.0 branch.
Since we need some specified step to try on WVGA device (partial can be tested
on Nightly), if you care about the changes and would like to do a full review,
you may set review flag after reviewing; otherwise, you may set feedback flag
and let me find an appropriate reviewer in Taipei to review and confirm on WVGA
device.
These 1.5x assets in patch are here temporarily for confirming we're making right
layout changes, and will be replaced later after visual team supplying newly made
1.5x assets.
The step for testing by HD is noted in Github comment. Thanks a lot!

Comment 3

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 768830 [details]
patch for this bug

Mostly looks good to me with a few comments on Github. Thank you!

May you try if you can eliminate the problem on |li| come from non-integer CSS pixel?

Comment 4

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: Screenshot

Comment 5

[Dale Harvey (:daleharvey)]

Comment on attachment 768830 [details]
patch for this bug

Looks good, cheers

Comment 6

[Dale Harvey (:daleharvey)]

Tested on peak and all looks to be working, thanks

Merged in: https://github.com/mozilla-b2g/gaia/commit/b351f42cac394d0c628c1096a802956be7d57842

Comment 7

[Gareth Aye [:gaye] (back from PTO)]

v1.1.0hd: b351f42cac394d0c628c1096a802956be7d57842
v1.1.0hd: a78f6caa647aca76783a7f63d0919ec2be6381a4

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) from comment #0)
> This bug represents fixes needed in Video app in order to deliver bug 881126:
> -- On master, drop the @1.5x and @2x images and make sure there is no
> more to tweak besides changes made on bug 830644.

Comment 9

[John Hu [:johnhu][:johu][:醬糊小弟]]

Thanks.

I create another patch for master.

Comment 10

[John Hu [:johnhu][:johu][:醬糊小弟]]

Attachment: new icons form patryk for 1.1hd

Comment 11

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 771143 [details]
new icons form patryk for 1.1hd

Because patryk gives us new icons, this patch replaces the correct icons or adds missing icons.

Comment 12

[John Hu [:johnhu][:johu][:醬糊小弟]]

Follow up bugs about missing icon: bug 890139

Comment 13

[John Hu [:johnhu][:johu][:醬糊小弟]]

Attachment: patch for master

Hi Dale, 

This patch is for master branch. I did the following things:
1. add 1.5x images
2. remove useless 2x images, btn_pause_off, btn_pause_press, btn_play_off, btn_pause_press.
3. change css settings, most of them are background-size and px to rem.

Comment 14

[John Hu [:johnhu][:johu][:醬糊小弟]]

merge icons patch to 1.1hd: 
https://github.com/mozilla-b2g/gaia/commit/75edcf31e61e937b5d383c7e17e9aebd2c031758

Comment 15

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 771154 [details]
patch for master

Looks good to me. thanks!

Comment 16

[John Hu [:johnhu][:johu][:醬糊小弟]]

merged to master:
https://github.com/mozilla-b2g/gaia/commit/97d72fdb7a532bb3b7970279b42b7462da1e78af

Comment 17

[John Ford [:jhford] CET/CEST Berlin Time]

v1.1.0hd: b351f42cac394d0c628c1096a802956be7d57842
v1.1.0hd: a78f6caa647aca76783a7f63d0919ec2be6381a4