Closed Bug 881193 Opened 7 years ago Closed 7 years ago

[Dialer] Hang up call that speaker mode is enabled, Speaker mode is on when making a call

Categories

(Firefox OS Graveyard :: Gaia::Dialer, defect)

ARM
Gonk (Firefox OS)
defect
Not set
major

Tracking

(blocking-b2g:leo+, b2g18 verified, b2g-v1.1hd fixed)

VERIFIED FIXED
1.1 QE3 (26jun)
blocking-b2g leo+
Tracking Status
b2g18 --- verified
b2g-v1.1hd --- fixed

People

(Reporter: leo.bugzilla.gaia, Assigned: arthurcc)

Details

(Whiteboard: leorun3)

Attachments

(2 files)

Attached video Speaker mode error
1. Title : Hang up call that speaker mode is enabled, Speaker mode is on when making a call
2. Precondition : In call >> Speaker mode on
3. Tester's Action : MO Call
4. Detailed Symptom : Speaker mode is on
5. Expected : Speaker mode is off
6. Reproducibility: Y
1) Frequency Rate : 100%
7. Gaia Master/v1-train : Reproduce
8. Gaia Revision : ce3b99781d182ad550a325206990c249b0dbcf0e
9. Personal email id : promise09th@gmail.com
blocking-b2g: leo? → leo+
Assignee: nobody → rlu
This issue was regressed by https://github.com/mozilla-b2g/gaia/commit/464f2729c8cba665a9161a85b77ed16f8e2c2079

CallScreen.syncSpeakerEnabled should be called after we change the speaker setting when handling the first incoming call.
When I receive incoming call, device turns off speaker. But when I make a new call, device turns on speaker
Please check this
Steal per discussion with Rudy.
Assignee: rlu → arthur.chen
Etienne, please help review the patch. Thanks!
Attachment #760790 - Flags: review?(etienne)
Comment on attachment 760790 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/10312

r=me (550410cd8becd2c72c3b515a10f43ff528c37a64)

Thanks! Sweet and simple.
Attachment #760790 - Flags: review?(etienne) → review+
Etienne, thanks for the quick review!
master: https://github.com/mozilla-b2g/gaia/commit/2ab2aa0b0bd89d31eb497480749b812c00475a1e
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Keywords: checkin-needed
This should be on John's uplift radar with a checkin-needed.
Keywords: checkin-needed
Uplifted 2ab2aa0b0bd89d31eb497480749b812c00475a1e to:
v1-train: 9b2b3b031b7a05845fa22a22d1b047a6060ec146
Seems like the Leo build for the test run does not include this fixed yet. 

Test Case: #2093
Whiteboard: leorun3
1.1hd: 9b2b3b031b7a05845fa22a22d1b047a6060ec146
This issue reproduces on the Leo Build ID: 20130625070217

Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/29933d1937db
Gaia: 1436e2778b90bd74635b0b94d1cf8ccb0d71b60c
Platform Version: 18.1

Speaker phone will be automatically enabled when placing a call after hanging up on a call using speaker phone.
The issue does not repro anymore. When the user hangs up on the first call (with speaker enabled) and makes the second call the speaker phone is off . 

Leo Build ID: 
Build ID: 20130625070217
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/29933d1937db
Gaia: 1436e2778b90bd74635b0b94d1cf8ccb0d71b60c
Platform Version: 18.1
RIL Version: 01.01.00.019.138
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.