881193 - [Dialer] Hang up call that speaker mode is enabled, Speaker mode is on when making a call

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Leo]

Attachment: Speaker mode error

1. Title : Hang up call that speaker mode is enabled, Speaker mode is on when making a call
2. Precondition : In call >> Speaker mode on
3. Tester's Action : MO Call
4. Detailed Symptom : Speaker mode is on
5. Expected : Speaker mode is off
6. Reproducibility: Y
1) Frequency Rate : 100%
7. Gaia Master/v1-train : Reproduce
8. Gaia Revision : ce3b99781d182ad550a325206990c249b0dbcf0e
9. Personal email id : [e-mail]

Comment 1

[Arthur Chen [:arthurcc][inactive after 6/30]]

This issue was regressed by https://github.com/mozilla-b2g/gaia/commit/464f2729c8cba665a9161a85b77ed16f8e2c2079

CallScreen.syncSpeakerEnabled should be called after we change the speaker setting when handling the first incoming call.

Comment 2

[Leo]

When I receive incoming call, device turns off speaker. But when I make a new call, device turns on speaker
Please check this

Comment 3

[Arthur Chen [:arthurcc][inactive after 6/30]]

Steal per discussion with Rudy.

Comment 4

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: Link to https://github.com/mozilla-b2g/gaia/pull/10312

Etienne, please help review the patch. Thanks!

Comment 5

[Etienne Segonzac (:etienne)]

Comment on attachment 760790 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/10312

r=me (550410cd8becd2c72c3b515a10f43ff528c37a64)

Thanks! Sweet and simple.

Comment 6

[Arthur Chen [:arthurcc][inactive after 6/30]]

Etienne, thanks for the quick review!
master: https://github.com/mozilla-b2g/gaia/commit/2ab2aa0b0bd89d31eb497480749b812c00475a1e

Comment 7

[Ryan VanderMeulen [:RyanVM]]

This should be on John's uplift radar with a checkin-needed.

Comment 8

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 2ab2aa0b0bd89d31eb497480749b812c00475a1e to:
v1-train: 9b2b3b031b7a05845fa22a22d1b047a6060ec146

Comment 9

[isabelrios]

Seems like the Leo build for the test run does not include this fixed yet. 

Test Case: #2093

Comment 10

[John Ford [:jhford] CET/CEST Berlin Time]

1.1hd: 9b2b3b031b7a05845fa22a22d1b047a6060ec146

Comment 11

[Sarah Parsons]

This issue reproduces on the Leo Build ID: 20130625070217

Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/29933d1937db
Gaia: 1436e2778b90bd74635b0b94d1cf8ccb0d71b60c
Platform Version: 18.1

Speaker phone will be automatically enabled when placing a call after hanging up on a call using speaker phone.

Comment 12

[Deepa Subramanian]

The issue does not repro anymore. When the user hangs up on the first call (with speaker enabled) and makes the second call the speaker phone is off . 

Leo Build ID: 
Build ID: 20130625070217
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/29933d1937db
Gaia: 1436e2778b90bd74635b0b94d1cf8ccb0d71b60c
Platform Version: 18.1
RIL Version: 01.01.00.019.138