881226 - Change {Array, Map, Set} iterator methods to mach the latest spec

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Sankha Narayan Guria [:sankha]]

This is a follow up of bug 869996.

Quoting Rick's comments in bug 869996, the spec had been changed for the iterator methods of Set.

> Please see 15.16.6.2.2 SetIterator.prototype.next() of the latest
> specification draft.
> 
> .next() should produce an ItrResult object that has both a "value" and
> "done" property. The "value" property's own value will be as those shown
> above, the "done" property will be a boolean value that is |true| until
> there are no more values to yield, at which time it will have the boolean
> value |false|
> 
> See line 14 comments, StopIteration has been removed from the design of the
> feature

Comment 1

[Rick Waldron [:rwaldron]]

This actually applies to:

ArrayIterator.prototype.next()
MapIterator.prototype.next()
SetIterator.prototype.next()

Comment 2

[Sankha Narayan Guria [:sankha]]

I think this has been done for MapIterator and SetIterator objects? Wingo can you confirm?

Then I'll make the changes accordingly in bug 894658 for ArrayIterator methods.

Comment 3

[Andy Wingo [:wingo]]

As noted, see bug 919948.

Comment 4

[Sankha Narayan Guria [:sankha]]

This has been fixed.

Comment 5

[Jean-Yves Perrier [:teoli]]

For documentation purpose, in which release (and if possible in which bug to be able to access info in it).

Comment 6

[Sankha Narayan Guria [:sankha]]

This was done in bug 907077 for Sets, Maps and bug 919948 for the Array Iterators.

Comment 7

[Kohei Yoshino [:kohei]]

Added to the site compat doc:
https://developer.mozilla.org/en-US/Firefox/Releases/27/Site_Compatibility

Comment 8

[Tooru Fujisawa [:arai]]

Updated following documents:
  https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/@@iterator
  https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/prototype

Also, following are already updated:
  https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Map/@@iterator
  https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Map/prototype
  https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Set/@@iterator
  https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Set/prototype
  https://developer.mozilla.org/en-US/Firefox/Releases/27

Comment 9

[Florian Scholz (Open Web Docs)]

Reviewed, thanks :arai!