Closed
Bug 881410
Opened 11 years ago
Closed 11 years ago
Remove some TI code that was only used by JM
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(1 file)
13.82 KB,
patch
|
bhackett1024
:
review+
|
Details | Diff | Splinter Review |
Various unused fields like chunkIndex, and recompilation no longer needs the script + pc, just the script.
Attachment #760533 -
Flags: review?(bhackett1024)
Comment 1•11 years ago
|
||
Comment on attachment 760533 [details] [diff] [review]
Patch
Review of attachment 760533 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/jsinfer.cpp
@@ +2364,5 @@
> * Trigger recompilation of the script itself, if code was not previously
> * compiled with the specified information.
> */
> + if (!JITCodeHasCheck(script, kind))
> + cx->compartment->types.addPendingRecompile(cx, script);
JITCodeHasCheck will only return true when the script has no Ion jitcode at all, in which case addPendingRecompile shouldn't do anything. So I think that JITCodeHasCheck can additionally be removed, along with the RecompileKind enum.
Attachment #760533 -
Flags: review?(bhackett1024) → review+
Assignee | ||
Comment 2•11 years ago
|
||
Comment 3•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in
before you can comment on or make changes to this bug.
Description
•