Closed Bug 881410 Opened 7 years ago Closed 7 years ago

Remove some TI code that was only used by JM

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla24

People

(Reporter: jandem, Assigned: jandem)

References

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
Various unused fields like chunkIndex, and recompilation no longer needs the script + pc, just the script.
Attachment #760533 - Flags: review?(bhackett1024)
Comment on attachment 760533 [details] [diff] [review]
Patch

Review of attachment 760533 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsinfer.cpp
@@ +2364,5 @@
>       * Trigger recompilation of the script itself, if code was not previously
>       * compiled with the specified information.
>       */
> +    if (!JITCodeHasCheck(script, kind))
> +        cx->compartment->types.addPendingRecompile(cx, script);

JITCodeHasCheck will only return true when the script has no Ion jitcode at all, in which case addPendingRecompile shouldn't do anything.  So I think that JITCodeHasCheck can additionally be removed, along with the RecompileKind enum.
Attachment #760533 - Flags: review?(bhackett1024) → review+
https://hg.mozilla.org/mozilla-central/rev/407dd32db3b0
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.