881424 - SimplePush: Enable push by default on b2g

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Set the prefs.

Comment 1

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Attachment: Set the SimplePush serverURL

Comment 2

[JR Conlin [:jrconlin,:jconlin]]

Comment on attachment 763831 [details] [diff] [review]
Set the SimplePush serverURL

Current push server uses wss://push.services.mozilla.com/

I can handle both URLs if that makes things easier.

Comment 3

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Attachment: Set the SimplePush serverURL

Drop the /ws

Comment 5

[JR Conlin [:jrconlin,:jconlin]]

Comment on attachment 763857 [details] [diff] [review]
Set the SimplePush serverURL

Review of attachment 763857 [details] [diff] [review]:
-----------------------------------------------------------------

Would prefer if there was a "/" at the end of the URL, however will + for the time being since the server accepts it.

Comment 6

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Landed with trailing slash.

http://hg.mozilla.org/projects/birch/rev/20acf89efc15

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/20acf89efc15

Comment 8

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Comment on attachment 763857 [details] [diff] [review]
Set the SimplePush serverURL

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky): 
String or UUID changes made by this patch:

Comment 9

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 822712
User impact if declined: Push isn't available despite code being present
Testing completed: A few months of testing from both Moz and Tef.
Risk to taking this patch (and alternatives if risky): 
Low risk. This simply enables push and sets a default URL. Until app developers use it, it won't affect network or battery.
String or UUID changes made by this patch:
Does a pref change count as a string change?

Comment 10

[Doug Turner (:dougt)]

Comment on attachment 763857 [details] [diff] [review]
Set the SimplePush serverURL

push needs to be enabled on b2g 1.1 by default.

Comment 11

[Jason Smith [:jsmith]]

(In reply to Doug Turner (:dougt) from comment #10)
> Comment on attachment 763857 [details] [diff] [review]
> Set the SimplePush serverURL
> 
> push needs to be enabled on b2g 1.1 by default.

Not to be a process nut, but we aren't accepting approvals anymore for 1.1, as we're past June 10th. This needs a leo+ to land.

Comment 12

[Antonio Manuel Amaya Calvo (:amac)]

This is a product requirement on our part (having push as part of the builds), so nominating it.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/649ce67cbb7b

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/649ce67cbb7b

Comment 15

[Alex Keybl [:akeybl]]

I've pinged doug about this. It should not have gotten approval without QA testing and driver buy-in to enable the feature in 1.1. Backout may be incoming.

Comment 16

[Alex Keybl [:akeybl]]

(In reply to Alex Keybl [:akeybl] from comment #15)
> I've pinged doug about this. It should not have gotten approval without QA
> testing and driver buy-in to enable the feature in 1.1. Backout may be
> incoming.

We discussed - push is a commitment even though it was disabled, people testing were enabling this pref on their own in 1.1 builds, and we've had good testing coverage from partners and services QA.

Comment 17

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

This seems to have landed on v1.1 hd but not v1.1?

Comment 19

[Ryan VanderMeulen [:RyanVM]]

Comment 13 would suggest otherwise...