Closed
Bug 881468
Opened 12 years ago
Closed 12 years ago
Event listener not properly removed in BrowserTabList
Categories
(DevTools :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 24
People
(Reporter: Fallen, Assigned: Fallen)
References
Details
Attachments
(1 file, 1 obsolete file)
|
1.99 KB,
patch
|
jimb
:
review+
|
Details | Diff | Splinter Review |
http://hg.mozilla.org/mozilla-central/annotate/9ca690835a5e/toolkit/devtools/server/actors/webbrowser.js#l393
The addEventListener call has makeInfallible(handleLoad.bind(this)) passed, but the removeEventListener call just has handleLoad.
I would be happy to hear this has changed, but afaik the add and remove calls must have the same handler object passed to work correctly
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #760582 -
Flags: review?(jimb)
|
|
Assignee | |
Updated•12 years ago
|
Blocks: tb-debugger
|
||
Updated•12 years ago
|
Attachment #760582 -
Attachment is patch: true
Attachment #760582 -
Attachment mime type: text/x-patch → text/plain
|
|
Assignee | |
Comment 2•12 years ago
|
||
Better yet, use the new arrow functions I just read up on.
Attachment #760582 -
Attachment is obsolete: true
Attachment #760582 -
Flags: review?(jimb)
Attachment #760828 -
Flags: review?(jimb)
|
||
Comment 3•12 years ago
|
||
Comment on attachment 760828 [details] [diff] [review]
Fix - v2
Review of attachment 760828 [details] [diff] [review]:
-----------------------------------------------------------------
Ah, thanks for finding and fixing this. Indeed, that code is bogus.
Attachment #760828 -
Flags: review?(jimb) → review+
|
|
Assignee | |
Updated•12 years ago
|
Whiteboard: [land-in-fx-team]
|
||
Comment 4•12 years ago
|
||
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
|
||
Comment 5•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 24
|
||
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•