881468 - Event listener not properly removed in BrowserTabList

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

http://hg.mozilla.org/mozilla-central/annotate/9ca690835a5e/toolkit/devtools/server/actors/webbrowser.js#l393

The addEventListener call has makeInfallible(handleLoad.bind(this)) passed, but the removeEventListener call just has handleLoad.

I would be happy to hear this has changed, but afaik the add and remove calls must have the same handler object passed to work correctly

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v1

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v2

Better yet, use the new arrow functions I just read up on.

Comment 3

[Jim Blandy :jimb]

Comment on attachment 760828 [details] [diff] [review]
Fix - v2

Review of attachment 760828 [details] [diff] [review]:
-----------------------------------------------------------------

Ah, thanks for finding and fixing this. Indeed, that code is bogus.

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/98b40ac6ed9a

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/98b40ac6ed9a