881486 - Automatically created tables vs. auth.sql_to_user.sql_migration.txt

Status: RESOLVED FIXED

(Cloud Services :: Server: Core, defect)

Description

[u422471]

Hi,

just noticed that there is a big difference between the automatically created tables in an empty database and the migrations/auth.sql_to_user.sql_migration.txt migration instructions:

auth.sql_to_user.sql_migration.txt:

username varbinary(32) not null
password varbinary(128)
accountStatus int(11) default 1
mailVerified int(11) default 0


automatically created tables:

username varchar(32) not null
password varchar(128)
accountStatus int(11)
mailVerified int(11)


It could be useful to modify one of the above to match the correct ones which should be used.

Comment 1

[Ryan Kelly [:rfkelly]]

Attachment: patch to fix table declarations

Yikes.  Here's a fix to what I think the right setup should be.

Comment 2

[Toby Elliott [:telliott]]

Comment on attachment 760770 [details] [diff] [review]
patch to fix table declarations

I don't actually think varbinary/varchar makes any difference in this case, since we control the charset of the password, and they should be the same. Doesn't hurt to fix it.

The server_default versus default thing is kind of clownshoes. ORMs :P

Comment 3

[Ryan Kelly [:rfkelly]]

http://hg.mozilla.org/services/server-core/rev/98e9f9294cfd