881507 - java.lang.NoSuchMethodError: android.view.MenuItem.getActionProvider at org.mozilla.gecko.menu.GeckoMenu.onMenuItemClick(GeckoMenu.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Scoobidiver (away)]

It has been hit three times in 24.0a1/20130610 by the same user on Honeycomb 3.1 (API version 12). Here is a crash report: bp-6b30ef6b-8b96-4f2a-8c0b-2df262130610.

It happens when accessing Tools according to comments.

java.lang.NoSuchMethodError: android.view.MenuItem.getActionProvider
	at org.mozilla.gecko.menu.GeckoMenu.onMenuItemClick(GeckoMenu.java:397)
	at org.mozilla.gecko.menu.GeckoMenuItem.onClick(GeckoMenuItem.java:395)
	at org.mozilla.gecko.menu.GeckoMenu.onItemClick(GeckoMenu.java:385)
	at android.widget.AdapterView.performItemClick(AdapterView.java:282)
	at android.widget.AbsListView.performItemClick(AbsListView.java:1136)
	at android.widget.AbsListView$PerformClick.run(AbsListView.java:2628)
	at android.widget.AbsListView$1.run(AbsListView.java:3404)
	at android.os.Handler.handleCallback(Handler.java:587)
	at android.os.Handler.dispatchMessage(Handler.java:92)
	at android.os.Looper.loop(Looper.java:132)
	at android.app.ActivityThread.main(ActivityThread.java:4028)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:491)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:844)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:602)
	at dalvik.system.NativeStart.main(Native Method)

More reports at:
https://crash-stats.mozilla.com/report/list?signature=java.lang.NoSuchMethodError%3A+android.view.MenuItem.getActionProvider+at+org.mozilla.gecko.menu.GeckoMenu.onMenuItemClick%28GeckoMenu.java%29

Comment 1

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

ActionProviders are available only 14+. Hence covering the if condition with a nice little ( :sarcasm: ) Build.VERSION check. JIT is happy, users happy, so am I :D

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 760637 [details] [diff] [review]
Patch

We should consider pulling the "getActionProvider()" out into it's own function. I assume we could move it to GeckoMenuItem. What do you think?

Comment 3

[Sriram Ramasubramanian [:sriram]]

That would require a new method, hasActionProvider() or something else. I can do that. I'm fine with the above approach too. The getActionProvider() won't called if the device is not a 14+ device.

Comment 4

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch: Option 2

Moving the condition inside GeckoMenuItem.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 761031 [details] [diff] [review]
Patch: Option 2

Thanks

Comment 6

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/095b953d91b9

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/095b953d91b9