Closed
Bug 881776
Opened 11 years ago
Closed 11 years ago
Editing mode is overriden with "about:home" when started before gecko
Categories
(Firefox for Android Graveyard :: Awesomescreen, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 26
People
(Reporter: lucasr, Unassigned)
References
Details
(Whiteboard: fixed-fig)
Attachments
(1 file)
|
1.26 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
If you start editing mode before gecko finishes loading, the content of the url entry is overriden with "about:home".
|
Reporter | |
Comment 1•11 years ago
|
||
Attachment #760997 -
Flags: review?(mark.finkle)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 760997 [details] [diff] [review] Only update entry with title updates when not editing This is fine, but I wonder if we should update the title at all if editing. Maybe we should just return right away.
Attachment #760997 -
Flags: review?(mark.finkle) → review+
|
|
Reporter | |
Comment 3•11 years ago
|
||
(In reply to Mark Finkle (:mfinkle) from comment #2) > Comment on attachment 760997 [details] [diff] [review] > Only update entry with title updates when not editing > > This is fine, but I wonder if we should update the title at all if editing. > Maybe we should just return right away. We do need to update title because we want to show the latest page title in case editing mode is dismissed.
|
|
Reporter | |
Comment 4•11 years ago
|
||
Pushed: http://hg.mozilla.org/projects/fig/rev/7956d9860adc
Whiteboard: fixed-fig
|
||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7956d9860adc
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
|
||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•