881834 - Pre-check features from manifest new version upload

Status: VERIFIED FIXED

(Marketplace Graveyard :: Developer Pages, defect, P1)

Description

[Chuck Harmston [:chuck]]

Bug 862443 added capabilities to the validator to detect required features (i.e. buchets) in the validator. We should use this information to pre-check the appropriate feature checkboxes during both new app submission and new version upload to existing apps.

This was previously a part of 875005, but the overlap with new version submission warrants a separate bug.

Comment 1

[Chuck Harmston [:chuck]]

Marked P3 as this is a UI enhancement that, though very important, should probably be deprioritized to core buchet functionality.

Comment 2

[Christopher Van Wiemeersch [:cvan]]

Basta already made this happen in Zamboni (bug 862443 and bug 879379).

Comment 4

[Mathieu Pillard [:mat]]

Note: currently, checkboxes are not pre-checked either when editing an *existing* version that has some features.

Comment 6

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/e8a3985

Comment 7

[Iulian Timis]

Buchets are now checked for the original uploaded version in Manage Version page, but are not updated when a new version is uploaded.
Please see screencast http://screencast.com/t/dlmRNk7ZBEq

Comment 8

[Christopher Van Wiemeersch [:cvan]]

I'm afraid this is due to caching:

	>>> v.features.update(has_sms=True)
	>>> AppFeatures.uncached.filter(version_id=1451705)[0].to_list()
	[]
	>>> v.features.has_sms=True
	>>> v.features.save()
	>>> AppFeatures.uncached.filter(version_id=1451705)[0].to_list()
	[]
	>>> AppFeatures.uncached.filter(version_id=1451705)[0].has_sms
	False
	>>> v.features
	<AppFeatures: Version: 1451705: 400.32.1>
	>>> v.features == AppFeatures.uncached.filter(version_id=1451705)[0]
	True
	>>> AppFeatures.uncached.filter(version_id=1451705)[0].to_list()
	[]
	>>> v.features
	<AppFeatures: Version: 1451705: 400.32.1>
	>>> v.features.to_list()
	[<django.utils.functional.__proxy__ object at 0x25f6d10>]
	>>> AppFeatures.uncached.filter(version_id=1451705)[0].to_list()
	[]

	1 hour later...

	>>> AppFeatures.uncached.filter(version_id=1451705)[0] == Version.objects.get(id=1451705).features
	True
	>>> AppFeatures.uncached.filter(version_id=1451705)[0].to_list()
	[<django.utils.functional.__proxy__ object at 0x292fd10>]
	>>> Version.objects.get(id=1451705).features.to_list()
	[<django.utils.functional.__proxy__ object at 0x292fd10>]

Will try to figure out something.

Comment 9

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/6962ea0

Comment 10

[Christopher Van Wiemeersch [:cvan]]

post-fix screenshot

http://f.cl.ly/items/1g1Q0S1h3S1y0B2k422F/Screen%20Shot%202013-07-16%20at%205.30.27%20PM.png

HECK YEAH!

Comment 11

[Iulian Timis]

Should the new uploaded version of the app also have Smartphone-Sized Displays feature selected as the first version? 
Please see screencast http://screencast.com/t/g2vDbqb8eKp

Comment 12

[Christopher Van Wiemeersch [:cvan]]

(In reply to Iulian Timis from comment #11)
> Should the new uploaded version of the app also have Smartphone-Sized
> Displays feature selected as the first version? 
> Please see screencast http://screencast.com/t/g2vDbqb8eKp

https://github.com/mozilla/zamboni/commit/9dc1a94

Done - thanks!

Comment 13

[Iulian Timis]

Verified as fixed in https://marketplace-dev.allizom.org/developers/ on FF25 (Win 7).
Postfix screencast http://screencast.com/t/4YmDYxwu
Closing bug.