Closed Bug 881868 Opened 11 years ago Closed 11 years ago

Defect - Snapped view autocomplete screen internet search results displays horizontally

Categories

(Firefox for Metro Graveyard :: Browser, defect)

x86_64
Windows 8
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 858388

People

(Reporter: bbondy, Assigned: sfoster)

References

Details

(Whiteboard: feature=defect c=Snapped_view u=metro_firefox_user p=0)

Attachments

(2 files)

1. Open Firefox Metro in snapped view.
2. Type something in the URL bar

Actual results:
a) Your results displays vertically (good)
b) Search results displays horizontally (bad)

Expect results:
a) This is good as is
b) This should display vertically
See screenshot for a visual description
Summary: Snapped view autocomplete screen internet search results displays horizontally → Defect - Snapped view autocomplete screen internet search results displays horizontally
Whiteboard: feature=defect c=Snapped_view u=metro_firefox_user p=0
p=1
Assignee: nobody → sfoster
Adds call to arrangeItems on the searches grid, which otherwise never get layed out properly

Turns out the autocomplete searches grid never has its arrangeItems called. I've added it to updateSearchEngineSubtitles, which is called from invalidate, which ends up doing what we want, when we want it.

It might be nice to follow up at some point with a more explicit sequence that says: prepare the contents, show the popup and layout the grids, as there's enough indirection and setTimeout-ery going on here that its not very clear.
Attachment #762735 - Flags: review?(rsilveira)
Comment on attachment 762735 [details] [diff] [review]
Adds call to arrangeItems on the searches grid, which otherwise never get layed out properly

Issue still reproduces with this patch when at > 100% display sizing.
Attachment #762735 - Flags: review?(rsilveira)
This is actually the same issue as bug 858388, just horizontal instead of vertical because of the orient direction value of the container. I'll integrate the arrangeItems patch to the work done over there, update its title and dupe this one.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → DUPLICATE
No longer blocks: metrov1defect&change
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: