881875 - Pref on media.navigator.enabled and media.peerconnection.enabled on FxAndroid Nightly

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Jason Smith [:jsmith]]

Pref on the WebRTC prefs by default.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Now that bug 874401 landed on inbound, we should be good to go.

Comment 2

[Jason Smith [:jsmith]]

Talked with Wes about what's needed before we land the pref on. I think we need to fix bug 882136 before we pref on. Other than that, I think we're okay.

Comment 3

[Wesley Johnston (:wesj)]

Attachment: Patch

This flips the pref on non-release builds. I think that would be fine for now while we wait for other issues to be fixed?

Comment 4

[Gian-Carlo Pascutto [:gcp]]

Comment on attachment 764853 [details] [diff] [review]
Patch

Review of attachment 764853 [details] [diff] [review]:
-----------------------------------------------------------------

1) Why not pref on in beta/release, if we believe all blockers for pref on are fixed? If there turn out to be critical issues we can backout in aurora/beta. No reason to believe we won't enable in beta/rel for now.

2) I think you can just remove the prefs and it'll default on, so just remove those settings from that file entirely.

Comment 5

[Gian-Carlo Pascutto [:gcp]]

Attachment: Patch 1. v2 Pref on WebRTC

Comment 6

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 765350 [details] [diff] [review]
Patch 1. v2 Pref on WebRTC

Review of attachment 765350 [details] [diff] [review]:
-----------------------------------------------------------------

I'm assuming this defaults to true.

Comment 7

[Gian-Carlo Pascutto [:gcp]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a473e89432f3

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a473e89432f3

Comment 9

[Jason Smith [:jsmith]]

lgtm on 6/21 build - it's preffed on by default

Comment 10

[bhavana bajaj [:bajaj]]

Spoke to wes and he said one note around the entire WebRTC should suffice so instead tracked Bug 750010