Closed Bug 881978 Opened 7 years ago Closed 7 years ago

[webvtt] Move WebVTTLoadListener's call backs to be private

Categories

(Core :: Audio/Video, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla24

People

(Reporter: reyre, Assigned: caitlin.potter)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Right now WebVTTLoadListener's OnParsedCue() and OnParsedError() callbacks are public. They do not need to be.

public:
  void OnParsedCue(webvtt_cue* aCue);
  void OnReportError(uint32_t aLine, uint32_t aCol, webvtt_error aError);
Blocks: webvtt
Assignee: nobody → caitlin.potter
Depends on: 881475
Quick patch to privatize the parsed cue/error handlers. Blocking on 881475 only because of the slightly changed OnReportError signature.

Let me know if it needs comments or something.
Attachment #761250 - Flags: review?(giles)
Attachment #761250 - Flags: feedback?(rick.eyre)
Minor fixup, that is all
Attachment #761250 - Attachment is obsolete: true
Attachment #761250 - Flags: review?(giles)
Attachment #761250 - Flags: feedback?(rick.eyre)
Attachment #761251 - Flags: review?(giles)
Attachment #761251 - Flags: feedback?(rick.eyre)
Comment on attachment 761251 [details] [diff] [review]
Make WebVTTLoadListener callbacks private. V2

Review of attachment 761251 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.
Attachment #761251 - Flags: feedback?(rick.eyre) → feedback+
Comment on attachment 761251 [details] [diff] [review]
Make WebVTTLoadListener callbacks private. V2

Review of attachment 761251 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.
Attachment #761251 - Flags: review?(giles) → review+
https://hg.mozilla.org/mozilla-central/rev/c8f9b8569b05
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.