881995 - Snapped view Alignment for Bookmarks an Recent History is off and tiles are cut off

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: Firefox Start, defect, P1)

Description

[Brian R. Bondy [:bbondy]]

In snapped view, when you click on "Bookmarks" or "Recent History", the alignment of the pages that come up in snapped view does
not match up with the default "Top Sites" view, and the tiles themselves are cut off. 

Yuan mentioned:
> Yes, we need to fix that. I don't have the pixels. 
> But I think shorlander should be able to give you the right 
> alignment and sizes of the tiles. Based on his mockup (The last 
> 2 mockups are our direction): 
> http://people.mozilla.com/~shorlander/files/design-specs-metro/metro-designSpecs-awesomeResults-splitView.html

Comment 1

[Brian R. Bondy [:bbondy]]

Needinfo request for right pixel number for alignment.

Comment 2

[Brian R. Bondy [:bbondy]]

p=1

Comment 3

[Sam Foster [:sfoster] (he/him)]

In snapped view, ideally the grid and its single column would be 100%/auto width, so the dimension is really dictated by the snapped view presets minus margins/padding etc

Comment 4

[Allison Naaktgeboren :ally]

I think this mostly manipulating the css to ensure it falls under the same set of rules that the snapped start tiles get. 

I had left them slightly off because I was waiting for the new grid that was going to lay it out in one column and figured there would be css changes then.

Comment 5

[Stephen Horlander [:shorlander]]

Attachment: Snap View Dimensions - 01

Comment 6

[Brian R. Bondy [:bbondy]]

Thanks Stephen!

Comment 7

[Sam Foster [:sfoster] (he/him)]

Attachment: Adds call to arrangeItems on the searches grid, which otherwise never get layed out properly

Turns out the autocomplete searches grid never has its arrangeItems called. I've added it to updateSearchEngineSubtitles, which is called from invalidate, which ends up doing what we want, when we want it.

It might be nice to follow up at some point with a more explicit sequence that says: prepare the contents, show the popup and layout the grids, as there's enough indirection and setTimeout-ery going on here that its not very clear.

Comment 8

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 762395 [details]
Adds call to arrangeItems on the searches grid, which otherwise never get layed out properly

Apologies, this belongs on a different bug

Comment 9

[Sam Foster [:sfoster] (he/him)]

Some of this is fixed in bug 828088, just some snapped case handling for the panels may remain.

Comment 10

[Marco Mucci [:MarcoM]]

The completion of Feature Story 892512 should resolve/invalidate 881995.  It has been added as a dependency so we can ensure the defect is fixed, as well as keep the context nearby.

Comment 11

[Rodrigo Silveira [:rsilveira] [:rodms]]

Attachment: Patch v1

The red line attached to this bug is for search results, used them as guidelines.

Comment 12

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 787205 [details] [diff] [review]
Patch v1

Review of attachment 787205 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

::: browser/metro/base/content/browser.xul
@@ +136,5 @@
>      <key id="key_open" key="o" modifiers="accel" command="cmd_openFile"/>
>      <key id="key_save" key="s" modifiers="accel" command="cmd_savePage"/>
>  
>      <!-- misc -->
> +    <key id="key_options" key="x" modifiers="accel,shift" oncommand="Elements.windowState.setAttribute('viewstate', 'snapped');Services.obs.notifyObservers(null, 'metro_viewstate_changed', 'snapped');" />

Is this a debugging aid for -metrodesktop? On http://windows.microsoft.com/en-us/windows-8/keyboard-shortcuts I see WIN+SHIFT+'.' to snap to left. Anyway, probably shouldnt be in this patch?

Comment 13

[Rodrigo Silveira [:rsilveira] [:rodms]]

Yes, that was a debugging aid, sorry! Removed and landed.

https://hg.mozilla.org/integration/fx-team/rev/d1140bb49990

Comment 14

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/d1140bb49990