Closed Bug 881995 Opened 7 years ago Closed 6 years ago

Snapped view Alignment for Bookmarks an Recent History is off and tiles are cut off

Categories

(Firefox for Metro Graveyard :: Firefox Start, defect, P1)

x86_64
Windows 8
defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 26

People

(Reporter: bbondy, Assigned: rsilveira)

References

Details

(Whiteboard: [Metro Preview] )

Attachments

(2 files, 1 obsolete file)

In snapped view, when you click on "Bookmarks" or "Recent History", the alignment of the pages that come up in snapped view does
not match up with the default "Top Sites" view, and the tiles themselves are cut off. 

Yuan mentioned:
> Yes, we need to fix that. I don't have the pixels. 
> But I think shorlander should be able to give you the right 
> alignment and sizes of the tiles. Based on his mockup (The last 
> 2 mockups are our direction): 
> http://people.mozilla.com/~shorlander/files/design-specs-metro/metro-designSpecs-awesomeResults-splitView.html
Needinfo request for right pixel number for alignment.
Flags: needinfo?(shorlander)
p=1
Summary: Snapped view Alignment for Bookmarks an Recent History is off and tiles are cut off → Defect - Snapped view Alignment for Bookmarks an Recent History is off and tiles are cut off
Whiteboard: feature=defect c=firefox_start u=metro_firefox_user p=0
In snapped view, ideally the grid and its single column would be 100%/auto width, so the dimension is really dictated by the snapped view presets minus margins/padding etc
I think this mostly manipulating the css to ensure it falls under the same set of rules that the snapped start tiles get. 

I had left them slightly off because I was waiting for the new grid that was going to lay it out in one column and figured there would be css changes then.
Thanks Stephen!
Turns out the autocomplete searches grid never has its arrangeItems called. I've added it to updateSearchEngineSubtitles, which is called from invalidate, which ends up doing what we want, when we want it.

It might be nice to follow up at some point with a more explicit sequence that says: prepare the contents, show the popup and layout the grids, as there's enough indirection and setTimeout-ery going on here that its not very clear.
Assignee: nobody → sfoster
Attachment #762395 - Flags: review?(mbrubeck)
Attachment #762395 - Flags: review?(mbrubeck) → review?(rsilveira)
Comment on attachment 762395 [details]
Adds call to arrangeItems on the searches grid, which otherwise never get layed out properly

Apologies, this belongs on a different bug
Attachment #762395 - Flags: review?(rsilveira)
Attachment #762395 - Attachment is obsolete: true
Attachment #762395 - Attachment is patch: false
Priority: -- → P1
Some of this is fixed in bug 828088, just some snapped case handling for the panels may remain.
Blocks: metrov1it10
No longer blocks: metrov1defect&change
Status: NEW → ASSIGNED
QA Contact: jbecerra
Whiteboard: feature=defect c=firefox_start u=metro_firefox_user p=0 → feature=defect c=firefox_start u=metro_firefox_user p=2
Blocks: 892512
The completion of Feature Story 892512 should resolve/invalidate 881995.  It has been added as a dependency so we can ensure the defect is fixed, as well as keep the context nearby.
Assignee: sfoster → nobody
No longer blocks: metrov1it10, 831919
Status: ASSIGNED → NEW
QA Contact: jbecerra
Summary: Defect - Snapped view Alignment for Bookmarks an Recent History is off and tiles are cut off → Snapped view Alignment for Bookmarks an Recent History is off and tiles are cut off
Whiteboard: feature=defect c=firefox_start u=metro_firefox_user p=2
Whiteboard: [preview-triage]
Whiteboard: [preview-triage] → [Metro Preview]
Attached patch Patch v1Splinter Review
The red line attached to this bug is for search results, used them as guidelines.
Assignee: nobody → rsilveira
Status: NEW → ASSIGNED
Attachment #787205 - Flags: review?(sfoster)
Comment on attachment 787205 [details] [diff] [review]
Patch v1

Review of attachment 787205 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

::: browser/metro/base/content/browser.xul
@@ +136,5 @@
>      <key id="key_open" key="o" modifiers="accel" command="cmd_openFile"/>
>      <key id="key_save" key="s" modifiers="accel" command="cmd_savePage"/>
>  
>      <!-- misc -->
> +    <key id="key_options" key="x" modifiers="accel,shift" oncommand="Elements.windowState.setAttribute('viewstate', 'snapped');Services.obs.notifyObservers(null, 'metro_viewstate_changed', 'snapped');" />

Is this a debugging aid for -metrodesktop? On http://windows.microsoft.com/en-us/windows-8/keyboard-shortcuts I see WIN+SHIFT+'.' to snap to left. Anyway, probably shouldnt be in this patch?
Attachment #787205 - Flags: review?(sfoster) → review+
Yes, that was a debugging aid, sorry! Removed and landed.

https://hg.mozilla.org/integration/fx-team/rev/d1140bb49990
https://hg.mozilla.org/mozilla-central/rev/d1140bb49990
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
You need to log in before you can comment on or make changes to this bug.