882 - nsButton not initializing mRefCnt

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect, P1)

Description

[troy]

Kevin,

Purify is complaining that the nsButton AddRef() member function is making an
uninitialized memory reference to mRefCnt.

That's because the Windows version of nsButton.h uses NS_DECL_ISUPPORTS which
gets a mRefCnt member data declared, but the constructor doesn't use
NS_INIT_REFCNT() to initialize the member data

I would have added that, but that isn't sufficient because nsBaseWidget also
uses NS_DECL_ISUPPORTS which means that nsButton really has two mRefCnt member
data. That's bad and needs to be fixed

Troy

Comment 1

[Kevin McCluskey (gone)]

Stopped using NS_DECL_ISUPPORTS macro on any Windows widget that derives
From nsBaseWidget.h. This removes the mRefCnt member variable defined through
the NS_DECL_ISUPPORTS macro. This problem was not confined to nsButton.h. I also
Modified  nsCheckButton.h,
nsComboBox.h, nsDialog.h, nsLabel.h, nsListBox.h, nsRadioButton.h since they all
used NS_DECL_ISUPPORTS and derived from nsBaseWidget.

-- Kevin

Comment 2

[Eli Goldberg]

[Pinged Troy by E-mail to request bug verification, since this is too deeply at
the code-level to be able to verify.]

Comment 3

[rubydoo123]

troy can you please verify -- thanks

Comment 4

[rubydoo123]

Troy provide a test case for verification

Comment 5

[rubydoo123]

based on discussion with Troy, marking bug as verified.

Comment 6

[leger]

Moving all Widget Set bugs, past and present, to new HTML Form Controls
component per request from karnaze.  Widget Set component will be retired
shortly.