Closed
Bug 882081
Opened 12 years ago
Closed 12 years ago
Restore bookmark indicator in TwoLinePageRow
Categories
(Firefox for Android Graveyard :: Awesomescreen, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 26
People
(Reporter: lucasr, Unassigned)
References
Details
(Whiteboard: fixed-fig)
Attachments
(1 file, 1 obsolete file)
|
7.13 KB,
patch
|
sriram
:
review+
|
Details | Diff | Splinter Review |
That little icon that appears at the rightmost side of the row when the page is a bookmark.
|
Reporter | |
Comment 1•12 years ago
|
||
Attachment #761507 -
Flags: review?(sriram)
|
|
||
Comment 2•12 years ago
|
||
Comment on attachment 761507 [details] [diff] [review]
Restore bookmark indicator in TwoLinePageRow
Review of attachment 761507 [details] [diff] [review]:
-----------------------------------------------------------------
Bookmark/Reading mode has to be a compound drawable in the url. We don't need ImageView here.
Attachment #761507 -
Flags: review?(sriram) → review-
|
|
||
Comment 3•12 years ago
|
||
Can I steal this patch? ;)
|
|
Reporter | |
Comment 4•12 years ago
|
||
Attachment #761957 -
Flags: review?(sriram)
|
|
Reporter | |
Updated•12 years ago
|
Attachment #761507 -
Attachment is obsolete: true
|
|
Reporter | |
Comment 5•12 years ago
|
||
It seems we'll need new assets for the bookmark/reader icons. Filed bug 882612 to track this.
|
|
||
Comment 6•12 years ago
|
||
Comment on attachment 761957 [details] [diff] [review]
Restore bookmark indicator in TwoLinePageRow
Review of attachment 761957 [details] [diff] [review]:
-----------------------------------------------------------------
Awesome :D
::: mobile/android/base/resources/layout/two_line_page_row.xml
@@ +16,2 @@
> android:layout_height="wrap_content"
> + android:layout_marginRight="10dip"
This will add margin to FadedTextView also. Please make it a margin only for url.
Attachment #761957 -
Flags: review?(sriram) → review+
|
|
Reporter | |
Comment 7•12 years ago
|
||
(In reply to Sriram Ramasubramanian [:sriram] from comment #6)
> Comment on attachment 761957 [details] [diff] [review]
> Restore bookmark indicator in TwoLinePageRow
>
> Review of attachment 761957 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> Awesome :D
>
> ::: mobile/android/base/resources/layout/two_line_page_row.xml
> @@ +16,2 @@
> > android:layout_height="wrap_content"
> > + android:layout_marginRight="10dip"
>
> This will add margin to FadedTextView also. Please make it a margin only for
> url.
Based on the specs[1], there is margin for the whole row (both title and url). Not entirely clear though. Ian?
[1] https://bug862793.bugzilla.mozilla.org/attachment.cgi?id=739728
Flags: needinfo?(ibarlow)
|
|
||
Comment 8•12 years ago
|
||
Sorry, I don't understand what you are asking me here.
Flags: needinfo?(ibarlow)
|
|
||
Comment 9•12 years ago
|
||
Ah, I see what you meant. The right margin should be 10dp
|
|
||
Comment 10•12 years ago
|
||
r+ for the patch then ;)
|
|
Reporter | |
Comment 11•12 years ago
|
||
Whiteboard: fixed-fig
|
|
||
Comment 12•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
|
||
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•