Closed
Bug 882105
Opened 12 years ago
Closed 12 years ago
NetworkManager.js error
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(blocking-b2g:leo+, firefox22 wontfix, firefox23 wontfix, firefox24 fixed, b2g18 fixed, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 wontfix, b2g-v1.1hd fixed)
People
(Reporter: gerard-majax, Assigned: gerard-majax)
References
Details
(Keywords: regression, Whiteboard: [fixed-in-birch])
Attachments
(1 file, 1 obsolete file)
1.75 KB,
patch
|
vicamo
:
review+
|
Details | Diff | Splinter Review |
E/GeckoConsole( 110): [JavaScript Error: "regNetwork is undefined" {file: "jar:file:///system/b2g/omni.ja!/components/NetworkManager.js" line: 302}]
This is due to a typo of me in bug 875390
Assignee | ||
Comment 1•12 years ago
|
||
Please find attached a patch that correct the typo
Attachment #761379 -
Flags: review?(vyang)
Comment 2•12 years ago
|
||
Comment on attachment 761379 [details] [diff] [review]
Fix.
Review of attachment 761379 [details] [diff] [review]:
-----------------------------------------------------------------
Since you're here, please also move that line into if-is-mms-block. Thank you :)
Attachment #761379 -
Flags: review?(vyang) → review+
Assignee | ||
Comment 3•12 years ago
|
||
Changing :)
Attachment #761379 -
Attachment is obsolete: true
Attachment #761402 -
Flags: review?(vyang)
Comment 4•12 years ago
|
||
Comment on attachment 761402 [details] [diff] [review]
Fix v2.
Review of attachment 761402 [details] [diff] [review]:
-----------------------------------------------------------------
Hi Lissy,
If someone has marked your patches with r+, he means there are only some small nits to fix and you may skip raising another review. :)
Attachment #761402 -
Flags: review?(vyang) → review+
Comment 5•12 years ago
|
||
Whiteboard: [fixed-in-birch]
Comment 6•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
blocking-b2g: leo? → leo+
Comment 7•12 years ago
|
||
Assignee: nobody → lissyx+mozillians
status-b2g18:
--- → fixed
status-b2g18-v1.0.0:
--- → wontfix
status-b2g18-v1.0.1:
--- → wontfix
status-b2g-v1.1hd:
--- → affected
status-firefox22:
--- → wontfix
status-firefox23:
--- → wontfix
status-firefox24:
--- → fixed
Target Milestone: --- → 1.1 QE3 (24jun)
Comment 8•12 years ago
|
||
Updated•12 years ago
|
Flags: in-moztrap-
You need to log in
before you can comment on or make changes to this bug.
Description
•