882129 - [MMS] [UX] Thread view. Spinner inside bubbles should be centered in the 4 rem margin

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Victoria Gerchinhoren [:vicky]]

Attachment: Shows bug and proposed alignment

The spinner indicating a message is still being sent, should be centered in the middle of the 4rem gap between the edge and beginning of the text inside the bubble.

Please see attachment showing implementation bug and suggestion.

Comment 1

[Mark Shiao]

Attachment: link to pull request

Hi Steve,

Can you please review?  Fixed spacing issue as mentioned in the ticket.  

Thanks,
Mark

Comment 2

[Steve Chung [:steveck]]

Comment on attachment 762485 [details]
link to pull request

Looks good, thanks for the adjustment!

Comment 3

[Steve Chung [:steveck]]

Merge in master : ab22d8a4adc1b8bb5d764f623b230760cc9c67b3

Comment 4

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted ab22d8a4adc1b8bb5d764f623b230760cc9c67b3 to:
v1-train: 3f8c55bef98f9c69b85ff2343474646947f67d64

Comment 5

[John Ford [:jhford] CET/CEST Berlin Time]

1.1hd: 3f8c55bef98f9c69b85ff2343474646947f67d64

Comment 6

[dkumar]

Varified,fixed on LEO 1.1 Mozilla RIL
Environmental Variables
Build ID: 20130717070237
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/582e3a7018b0
Gaia: c506c50adaaebcf729ac3c27887ba2931ab79040
Platform Version: 18.1
RIL Version: 01.01.00.019.158 

Issue does not reproduce the spinner is in the middle of the 4rem gap between the edge and beginning of the text inside the bubble.