Closed Bug 882129 Opened 7 years ago Closed 7 years ago

[MMS] [UX] Thread view. Spinner inside bubbles should be centered in the 4 rem margin

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

x86
macOS
defect
Not set

Tracking

(blocking-b2g:leo+, b2g18 verified, b2g-v1.1hd fixed)

RESOLVED FIXED
blocking-b2g leo+
Tracking Status
b2g18 --- verified
b2g-v1.1hd --- fixed

People

(Reporter: vicky, Assigned: mshiao)

References

Details

Attachments

(2 files)

The spinner indicating a message is still being sent, should be centered in the middle of the 4rem gap between the edge and beginning of the text inside the bubble.

Please see attachment showing implementation bug and suggestion.
Blocks: 872514
blocking-b2g: --- → leo?
blocking-b2g: leo? → leo+
Assignee: nobody → mshiao
Attached file link to pull request
Hi Steve,

Can you please review?  Fixed spacing issue as mentioned in the ticket.  

Thanks,
Mark
Attachment #762485 - Flags: review?(schung)
Comment on attachment 762485 [details]
link to pull request

Looks good, thanks for the adjustment!
Attachment #762485 - Flags: review?(schung) → review+
Merge in master : ab22d8a4adc1b8bb5d764f623b230760cc9c67b3
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Uplifted ab22d8a4adc1b8bb5d764f623b230760cc9c67b3 to:
v1-train: 3f8c55bef98f9c69b85ff2343474646947f67d64
1.1hd: 3f8c55bef98f9c69b85ff2343474646947f67d64
Varified,fixed on LEO 1.1 Mozilla RIL
Environmental Variables
Build ID: 20130717070237
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/582e3a7018b0
Gaia: c506c50adaaebcf729ac3c27887ba2931ab79040
Platform Version: 18.1
RIL Version: 01.01.00.019.158 

Issue does not reproduce the spinner is in the middle of the 4rem gap between the edge and beginning of the text inside the bubble.
You need to log in before you can comment on or make changes to this bug.