remove unused knowsSearchNntpExtension and allowsPosting attributes from nsIMsgFolder

RESOLVED FIXED in Thunderbird 24.0

Status

MailNews Core
Database
--
trivial
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: aceman, Assigned: sshagarwal)

Tracking

Trunk
Thunderbird 24.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

4 years ago
These 2 attributes seem unused:

http://mxr.mozilla.org/comm-central/source/mailnews/base/public/nsIMsgFolder.idl#288

/**
 * this should go into a news-specific interface
 */
readonly attribute boolean knowsSearchNntpExtension;

/**
 * this should go into a news-specific interface
 */
readonly attribute boolean allowsPosting;
(Assignee)

Comment 1

4 years ago
Created attachment 761950 [details] [diff] [review]
Patch
Attachment #761950 - Flags: feedback?(acelists)
(Assignee)

Updated

4 years ago
Status: NEW → ASSIGNED
(Reporter)

Comment 2

4 years ago
Comment on attachment 761950 [details] [diff] [review]
Patch

Review of attachment 761950 [details] [diff] [review]:
-----------------------------------------------------------------

That's it.
Attachment #761950 - Flags: review?(Pidgeot18)
Attachment #761950 - Flags: feedback?(acelists)
Attachment #761950 - Flags: feedback+
Comment on attachment 761950 [details] [diff] [review]
Patch

Review of attachment 761950 [details] [diff] [review]:
-----------------------------------------------------------------

nsIMsgFolder needs a UUID change. Other than that, this is good.
Attachment #761950 - Flags: review?(Pidgeot18) → review+
(Assignee)

Comment 4

4 years ago
Created attachment 762726 [details] [diff] [review]
Patch

Made the change. Carrying review from jcranmer.
Attachment #761950 - Attachment is obsolete: true
Attachment #762726 - Flags: review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/caee2460d3f1
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 24.0
You need to log in before you can comment on or make changes to this bug.