Closed
Bug 882502
Opened 11 years ago
Closed 11 years ago
remove unused knowsSearchNntpExtension and allowsPosting attributes from nsIMsgFolder
Categories
(MailNews Core :: Database, defect)
MailNews Core
Database
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 24.0
People
(Reporter: aceman, Assigned: sshagarwal)
Details
Attachments
(1 file, 1 obsolete file)
2.98 KB,
patch
|
sshagarwal
:
review+
|
Details | Diff | Splinter Review |
These 2 attributes seem unused: http://mxr.mozilla.org/comm-central/source/mailnews/base/public/nsIMsgFolder.idl#288 /** * this should go into a news-specific interface */ readonly attribute boolean knowsSearchNntpExtension; /** * this should go into a news-specific interface */ readonly attribute boolean allowsPosting;
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #761950 -
Flags: feedback?(acelists)
Assignee | ||
Updated•11 years ago
|
Status: NEW → ASSIGNED
Comment on attachment 761950 [details] [diff] [review] Patch Review of attachment 761950 [details] [diff] [review]: ----------------------------------------------------------------- That's it.
Attachment #761950 -
Flags: review?(Pidgeot18)
Attachment #761950 -
Flags: feedback?(acelists)
Attachment #761950 -
Flags: feedback+
Comment 3•11 years ago
|
||
Comment on attachment 761950 [details] [diff] [review] Patch Review of attachment 761950 [details] [diff] [review]: ----------------------------------------------------------------- nsIMsgFolder needs a UUID change. Other than that, this is good.
Attachment #761950 -
Flags: review?(Pidgeot18) → review+
Assignee | ||
Comment 4•11 years ago
|
||
Made the change. Carrying review from jcranmer.
Attachment #761950 -
Attachment is obsolete: true
Attachment #762726 -
Flags: review+
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 5•11 years ago
|
||
https://hg.mozilla.org/comm-central/rev/caee2460d3f1
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 24.0
You need to log in
before you can comment on or make changes to this bug.
Description
•