Closed Bug 882502 Opened 7 years ago Closed 7 years ago

remove unused knowsSearchNntpExtension and allowsPosting attributes from nsIMsgFolder

Categories

(MailNews Core :: Database, defect, trivial)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 24.0

People

(Reporter: aceman, Assigned: sshagarwal)

Details

Attachments

(1 file, 1 obsolete file)

These 2 attributes seem unused:

http://mxr.mozilla.org/comm-central/source/mailnews/base/public/nsIMsgFolder.idl#288

/**
 * this should go into a news-specific interface
 */
readonly attribute boolean knowsSearchNntpExtension;

/**
 * this should go into a news-specific interface
 */
readonly attribute boolean allowsPosting;
Attached patch Patch (obsolete) — Splinter Review
Attachment #761950 - Flags: feedback?(acelists)
Status: NEW → ASSIGNED
Comment on attachment 761950 [details] [diff] [review]
Patch

Review of attachment 761950 [details] [diff] [review]:
-----------------------------------------------------------------

That's it.
Attachment #761950 - Flags: review?(Pidgeot18)
Attachment #761950 - Flags: feedback?(acelists)
Attachment #761950 - Flags: feedback+
Comment on attachment 761950 [details] [diff] [review]
Patch

Review of attachment 761950 [details] [diff] [review]:
-----------------------------------------------------------------

nsIMsgFolder needs a UUID change. Other than that, this is good.
Attachment #761950 - Flags: review?(Pidgeot18) → review+
Attached patch PatchSplinter Review
Made the change. Carrying review from jcranmer.
Attachment #761950 - Attachment is obsolete: true
Attachment #762726 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/caee2460d3f1
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 24.0
You need to log in before you can comment on or make changes to this bug.