Last Comment Bug 882502 - remove unused knowsSearchNntpExtension and allowsPosting attributes from nsIMsgFolder
: remove unused knowsSearchNntpExtension and allowsPosting attributes from nsIM...
Status: RESOLVED FIXED
:
Product: MailNews Core
Classification: Components
Component: Database (show other bugs)
: Trunk
: All All
: -- trivial (vote)
: Thunderbird 24.0
Assigned To: Suyash Agarwal (:sshagarwal)
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-12 17:33 PDT by :aceman
Modified: 2013-06-25 05:23 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Patch (2.17 KB, patch)
2013-06-13 03:06 PDT, Suyash Agarwal (:sshagarwal)
Pidgeot18: review+
acelists: feedback+
Details | Diff | Splinter Review
Patch (2.98 KB, patch)
2013-06-14 09:07 PDT, Suyash Agarwal (:sshagarwal)
syshagarwal: review+
Details | Diff | Splinter Review

Description :aceman 2013-06-12 17:33:13 PDT
These 2 attributes seem unused:

http://mxr.mozilla.org/comm-central/source/mailnews/base/public/nsIMsgFolder.idl#288

/**
 * this should go into a news-specific interface
 */
readonly attribute boolean knowsSearchNntpExtension;

/**
 * this should go into a news-specific interface
 */
readonly attribute boolean allowsPosting;
Comment 1 Suyash Agarwal (:sshagarwal) 2013-06-13 03:06:23 PDT
Created attachment 761950 [details] [diff] [review]
Patch
Comment 2 :aceman 2013-06-13 03:17:55 PDT
Comment on attachment 761950 [details] [diff] [review]
Patch

Review of attachment 761950 [details] [diff] [review]:
-----------------------------------------------------------------

That's it.
Comment 3 Joshua Cranmer [:jcranmer] 2013-06-13 20:12:36 PDT
Comment on attachment 761950 [details] [diff] [review]
Patch

Review of attachment 761950 [details] [diff] [review]:
-----------------------------------------------------------------

nsIMsgFolder needs a UUID change. Other than that, this is good.
Comment 4 Suyash Agarwal (:sshagarwal) 2013-06-14 09:07:39 PDT
Created attachment 762726 [details] [diff] [review]
Patch

Made the change. Carrying review from jcranmer.
Comment 5 Ryan VanderMeulen [:RyanVM] 2013-06-14 19:53:48 PDT
https://hg.mozilla.org/comm-central/rev/caee2460d3f1

Note You need to log in before you can comment on or make changes to this bug.