882514 - OdinMonkey: TryEnablingIon fails for arrow functions FFI call with --ion-eager

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: proposed fix

(function m(a,ffi){"use asm"; var f = ffi.f; function g(){f();}return g})(this, {f: x=>x})

raises an assertion failure as the arrow function has no script, in TryEnablingIon.
Present in a test case of bug 882012.

Comment 1

[Luke Wagner [:luke]]

Don't forget to add the testcase to the patch.

Comment 2

[Benjamin Bouvier [:bbouvier] (inactive)]

(In reply to Luke Wagner [:luke] from comment #1)
> Don't forget to add the testcase to the patch.

Should I move the test case present in the patch of bug 882012 in this patch?

Comment 3

[Luke Wagner [:luke]]

That'd probably be best (for the bug/hg record).

Comment 4

[Hannes Verschore [:h4writer]]

Comment on attachment 761821 [details] [diff] [review]
proposed fix

Review of attachment 761821 [details] [diff] [review]:
-----------------------------------------------------------------

Nice find. Seems like we don't have testcase testing ffi calls to natives yet! 
Please include a testcase.

::: js/src/ion/AsmJS.cpp
@@ +5231,5 @@
>  }
>  
>  static inline bool
> +TryEnablingIon(JSContext *cx, AsmJSModule::ExitDatum *exitDatum, int32_t argc, Value *argv)
> +{

Thanks for correcting the accolade.

@@ +5233,5 @@
>  static inline bool
> +TryEnablingIon(JSContext *cx, AsmJSModule::ExitDatum *exitDatum, int32_t argc, Value *argv)
> +{
> +    JSScript *script = exitDatum->fun->maybeNonLazyScript();
> +    if (script == NULL)

if (!script)

Comment 5

[Benjamin Bouvier [:bbouvier] (inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/05bf9122d234

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/05bf9122d234