882547 - Treat undefined values in dictionaries as missing

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Per discussion on the list.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Treat undefined values in WebIDL dictionaries as missing.

Example of the new codegen with a default value:

  if (isNull) {
    temp.setUndefined();
  } else if (!JS_GetPropertyById(cx, &val.toObject(), b_id, temp.address())) {
    return false;
  }
  if (!temp.isUndefined()) {
    if (!ValueToPrimitive<int32_t, eDefault>(cx, temp, &mB)) {
      return false;
    }
  } else {
    mB = 8;
  }

and without a default value:

  if (isNull) {
    temp.setUndefined();
  } else if (!JS_GetPropertyById(cx, &val.toObject(), a_id, temp.address())) {
    return false;
  }
  if (!temp.isUndefined()) {
    mA.Construct();
    if (!ValueToPrimitive<int32_t, eDefault>(cx, temp, &(mA.Value()))) {
      return false;
    }
  }

Comment 2

[Boris Zbarsky [:bzbarsky]]

For what it's worth, try push: https://tbpl.mozilla.org/?tree=Try&rev=43e7282ba506

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Something odd with the tryserver

Comment 4

[Boris Zbarsky [:bzbarsky]]

Yeah, more relevant try push at https://tbpl.mozilla.org/?tree=Try&rev=c765bc25d5b8

There is one failure in test_blobconstructor.html which does this:

34 blob = Blob([], {type: undefined});
35 ok(blob, "Blob should exist");
36 is(blob.type, "undefined", "Blob type should be stringified");

I believe I should just adjust this test.

Comment 5

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9432471a1c12

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9432471a1c12