Closed Bug 882578 Opened 11 years ago Closed 11 years ago

OS X doesn't need fgTabBackgroundMiddle

Categories

(Firefox :: Theme, defect)

All
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 28

People

(Reporter: mstange, Assigned: mstange)

References

Details

(Whiteboard: [Australis:M7])

Attachments

(1 file)

Attached patch patchSplinter Review
fgTabBackgroundMiddle is used on Windows to set the -moz-dialog background differently in the middle part and the start and end parts of a tab (gradient vs solid color). Mac needs a gradient in the whole tab, so it can just fgTabTexture in all tab parts and set fgTabBackgroundMiddle to none.
The HiDPI override was missing fgTabTexture. The corresponding part in tabs.inc.css looks like this:

.tab-background-middle[selected=true] {
  background-color: transparent;
  background-image: url(chrome://browser/skin/tabbrowser/tab-active-middle.png),
                    @fgTabTexture@,
                    @fgTabBackgroundMiddle@;
  background-repeat: repeat-x;
  background-size: auto 100%;
}
Attachment #761900 - Flags: review?(mnoorenberghe+bmo)
Hardware: ARM → All
Version: unspecified → Trunk
Comment on attachment 761900 [details] [diff] [review]
patch

Review of attachment 761900 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for all the OS X help :)
Attachment #761900 - Flags: review?(mnoorenberghe+bmo) → review+
https://hg.mozilla.org/projects/ux/rev/408f7960fc2b
Whiteboard: [Australis:M7] → [Australis:M7][fixed-in-ux]
https://hg.mozilla.org/mozilla-central/rev/408f7960fc2b
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:M7][fixed-in-ux] → [Australis:M7]
Target Milestone: --- → Firefox 28
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: