[webvtt] Ensure that TextTrackCue's setters call the time marches on algorithm

RESOLVED FIXED in Firefox 50

Status

()

Core
Audio/Video: Playback
RESOLVED FIXED
5 years ago
2 years ago

People

(Reporter: reyre, Assigned: bechen)

Tracking

Trunk
mozilla50
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox50 fixed)

Details

(URL)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
This has taken the place of CueChanged() function and has incorporated it.
(Reporter)

Updated

5 years ago
Blocks: 882700
(Reporter)

Updated

5 years ago
Depends on: 882718
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → WONTFIX
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
Component: Audio/Video → Audio/Video: Playback
(Assignee)

Updated

2 years ago
Assignee: nobody → bechen
(Assignee)

Updated

2 years ago
Depends on: 1275808
(Assignee)

Comment 1

2 years ago
Created attachment 8759130 [details]
Bug 882717 - Invoke TimeMarchesOn when the startTime/endTime/pauseOnExit be changed of TextTrackCue.

Review commit: https://reviewboard.mozilla.org/r/57192/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57192/
Attachment #8759130 - Flags: review?(giles)
Comment on attachment 8759130 [details]
Bug 882717 - Invoke TimeMarchesOn when the startTime/endTime/pauseOnExit be changed of TextTrackCue.

https://reviewboard.mozilla.org/r/57192/#review54056

Ok, so everything calls NotifyCueUpdate, which calls the MediaElement version, which calls the TextTrackManager version which calls TimeMarchesOn(). Whew!
Attachment #8759130 - Flags: review?(giles) → review+
(Assignee)

Updated

2 years ago
Blocks: 1278151
(Assignee)

Comment 3

2 years ago
https://reviewboard.mozilla.org/r/57192/#review55020

::: dom/media/TextTrack.cpp:120
(Diff revision 1)
> +    // Ensure the TimeMarchesOn is called in case that the mCueList
> +    // is empty.
> +    NotifyCueUpdated();

When the starttime or endtime is changed, the cue order in TextTrackList should be re-order too.
(Assignee)

Comment 4

2 years ago
Comment on attachment 8759130 [details]
Bug 882717 - Invoke TimeMarchesOn when the startTime/endTime/pauseOnExit be changed of TextTrackCue.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/57192/diff/1-2/
Attachment #8759130 - Attachment description: MozReview Request: Bug 882717 - Invoke TimeMarchesOn when the startTime/endTime/pauseOnExit be changed of TextTrackCue. r=rillian → Bug 882717 - Invoke TimeMarchesOn when the startTime/endTime/pauseOnExit be changed of TextTrackCue.
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 5

2 years ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1155115a7153
Invoke TimeMarchesOn when the startTime/endTime/pauseOnExit be changed of TextTrackCue. r=rillian
Keywords: checkin-needed

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1155115a7153
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago2 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.