882717 - [webvtt] Ensure that TextTrackCue's setters call the time marches on algorithm

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Rick Eyre (:reyre)]

This has taken the place of CueChanged() function and has incorporated it.

Comment 1

[Benjamin Chen [:bechen]]

Attachment: Bug 882717 - Invoke TimeMarchesOn when the startTime/endTime/pauseOnExit be changed of TextTrackCue.

Review commit: https://reviewboard.mozilla.org/r/57192/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57192/

Comment 2

[Ralph Giles (:rillian)]

Comment on attachment 8759130 [details]
Bug 882717 - Invoke TimeMarchesOn when the startTime/endTime/pauseOnExit be changed of TextTrackCue.

https://reviewboard.mozilla.org/r/57192/#review54056

Ok, so everything calls NotifyCueUpdate, which calls the MediaElement version, which calls the TextTrackManager version which calls TimeMarchesOn(). Whew!

Comment 3

[Benjamin Chen [:bechen]]

https://reviewboard.mozilla.org/r/57192/#review55020

::: dom/media/TextTrack.cpp:120
(Diff revision 1)
> +    // Ensure the TimeMarchesOn is called in case that the mCueList
> +    // is empty.
> +    NotifyCueUpdated();

When the starttime or endtime is changed, the cue order in TextTrackList should be re-order too.

Comment 4

[Benjamin Chen [:bechen]]

Comment on attachment 8759130 [details]
Bug 882717 - Invoke TimeMarchesOn when the startTime/endTime/pauseOnExit be changed of TextTrackCue.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/57192/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1155115a7153
Invoke TimeMarchesOn when the startTime/endTime/pauseOnExit be changed of TextTrackCue. r=rillian

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1155115a7153