Closed Bug 882717 Opened 7 years ago Closed 4 years ago

[webvtt] Ensure that TextTrackCue's setters call the time marches on algorithm

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: reyre, Assigned: bechen)

References

()

Details

Attachments

(1 file)

This has taken the place of CueChanged() function and has incorporated it.
Depends on: 882718
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
Component: Audio/Video → Audio/Video: Playback
Assignee: nobody → bechen
Depends on: 1275808
Comment on attachment 8759130 [details]
Bug 882717 - Invoke TimeMarchesOn when the startTime/endTime/pauseOnExit be changed of TextTrackCue.

https://reviewboard.mozilla.org/r/57192/#review54056

Ok, so everything calls NotifyCueUpdate, which calls the MediaElement version, which calls the TextTrackManager version which calls TimeMarchesOn(). Whew!
Attachment #8759130 - Flags: review?(giles) → review+
Blocks: 1278151
https://reviewboard.mozilla.org/r/57192/#review55020

::: dom/media/TextTrack.cpp:120
(Diff revision 1)
> +    // Ensure the TimeMarchesOn is called in case that the mCueList
> +    // is empty.
> +    NotifyCueUpdated();

When the starttime or endtime is changed, the cue order in TextTrackList should be re-order too.
Comment on attachment 8759130 [details]
Bug 882717 - Invoke TimeMarchesOn when the startTime/endTime/pauseOnExit be changed of TextTrackCue.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/57192/diff/1-2/
Attachment #8759130 - Attachment description: MozReview Request: Bug 882717 - Invoke TimeMarchesOn when the startTime/endTime/pauseOnExit be changed of TextTrackCue. r=rillian → Bug 882717 - Invoke TimeMarchesOn when the startTime/endTime/pauseOnExit be changed of TextTrackCue.
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1155115a7153
Invoke TimeMarchesOn when the startTime/endTime/pauseOnExit be changed of TextTrackCue. r=rillian
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/1155115a7153
Status: REOPENED → RESOLVED
Closed: 7 years ago4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.