882745 - Provide about:healthreport access to updater hook

Status: RESOLVED FIXED

(Firefox Health Report Graveyard :: Client: Android, defect, P2)

Comment 1

[Richard Newman [:rnewman]]

Just like chrome/content/about.xhtml.

Comment 2

[Richard Newman [:rnewman]]

MOZ_UPDATER is not defined on beta or release.

http://mxr.mozilla.org/mozilla-central/source/mobile/android/branding/official/configure.sh#7

See Bug 800397, Bug 766636.

So the UpdateHelperService does nada unless you're on Nightly or Aurora.

We should check for MOZ_UPDATER and open 

  https://play.google.com/store/apps/details?id=$ANDROID_PACKAGE_NAME

if it's not defined, or trigger the updater if it is. I'm happy to have a shoddy UI on Nightly/Aurora, because the updater should run automatically in these cases anyway.

If the Play URI doesn't open Play by default, then we should manually construct the intent.

Comment 3

[Nick Alexander :nalexander [he/him]]

Attachment: Add LaunchUpdater message to Android about:healthreport wrapper. r=rnewman

The code to launch the Play Store was stolen from
Feedback:OpenPlayStore; I have *not* device tested it.  I will do that
now.  (I have tested ignoring and opening about:.)

I provide a boolean return code that I'm not returning to the Jelly; I
don't care about the Jelly dealing with ignored update launches for
v1.

Comment 4

[Nick Alexander :nalexander [he/him]]

> The code to launch the Play Store was stolen from
> Feedback:OpenPlayStore; I have *not* device tested it.  I will do that
> now.  (I have tested ignoring and opening about:.)

Works on my Samsung Galaxy SII, Android 4.0.3 (with a testing patch).

Comment 5

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/services/services-central/rev/0b51d02bebd0

Comment 6

[Richard Newman [:rnewman]]

Comment on attachment 766049 [details] [diff] [review]
Add LaunchUpdater message to Android about:healthreport wrapper. r=rnewman

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
  New functionality to support initial set of FHR tips.

User impact if declined: 
  FHR will have very few actionable tips!

Testing completed (on m-c, etc.): 
  Just landed on s-c; Nick has tested manually.

Risk to taking this patch (and alternatives if risky): 
  Essentially zero; it's purely additive.
String or IDL/UUID changes made by this patch:

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/0b51d02bebd0

Comment 8

[bhavana bajaj [:bajaj]]

Comment on attachment 766049 [details] [diff] [review]
Add LaunchUpdater message to Android about:healthreport wrapper. r=rnewman

[Triage Comment]
Switching the aurora nom to beta and approving as this is needed for Fx23 beta 1 and confirmed its low risk.

Comment 9

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/releases/mozilla-beta/rev/86c2452fd56d