[webvtt] Fix assertion errors on debug builds for the new tests

RESOLVED FIXED in mozilla24

Status

()

Core
Audio/Video
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: reyre, Assigned: reyre)

Tracking

(Blocks: 1 bug)

Trunk
mozilla24
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
We're currently getting some assertion errors that we aren't expecting when we run our tests in the test suite.

https://tbpl.mozilla.org/?tree=Try&rev=449474f24c45

This is happening when we check the content load policy for the HTMLTrackElement. We pass in the HTMLTrackElement as an argument, but later Gecko seems to think it's not a window or DOM node and an assertion is thrown.
(Assignee)

Updated

4 years ago
Assignee: nobody → rick.eyre
Blocks: 629350, 833386, 882131
Status: NEW → ASSIGNED
(Assignee)

Comment 1

4 years ago
Created attachment 762454 [details] [diff] [review]
v1: Fix QI implementation of HTMLTrackElement

https://tbpl.mozilla.org/?tree=Try&rev=9f09df497708

The new tests don't show up in the try changesets added, but if you go to the log you can see them being run.
Attachment #762454 - Flags: review?(bzbarsky)
Comment on attachment 762454 [details] [diff] [review]
v1: Fix QI implementation of HTMLTrackElement

r=me
Attachment #762454 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 3

4 years ago
Created attachment 762460 [details] [diff] [review]
v1: Fix QI implementation of HTMLTrackElement r=bz

Just updated the commit message to include r=bz
Attachment #762454 - Attachment is obsolete: true
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/229c4d26630e
Keywords: checkin-needed
Comment on attachment 762460 [details] [diff] [review]
v1: Fix QI implementation of HTMLTrackElement r=bz

Review of attachment 762460 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/html/content/src/HTMLTrackElement.cpp
@@ +94,3 @@
>  
>  NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION_INHERITED(HTMLTrackElement)
>    NS_INTERFACE_MAP_ENTRY(nsIDOMHTMLElement)

NS_HTML_CONTENT_INTERFACES already deals with nsIDOMHTMLElement so this line is unnecessary.
(Assignee)

Comment 6

4 years ago
Do you want to back this out of the tree then or just a forward fix?
(Assignee)

Comment 7

4 years ago
Peter has recommended on IRC that we can just do a fix in the future. I'll open a bug for that and try to have a patch for it today.
https://hg.mozilla.org/mozilla-central/rev/229c4d26630e
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.