Last Comment Bug 882817 - [webvtt] Fix assertion errors on debug builds for the new tests
: [webvtt] Fix assertion errors on debug builds for the new tests
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Audio/Video (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla24
Assigned To: Rick Eyre (:reyre)
:
Mentors:
Depends on:
Blocks: webvtt 833386 882131
  Show dependency treegraph
 
Reported: 2013-06-13 11:16 PDT by Rick Eyre (:reyre)
Modified: 2013-06-14 18:59 PDT (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
v1: Fix QI implementation of HTMLTrackElement (1.11 KB, patch)
2013-06-13 19:27 PDT, Rick Eyre (:reyre)
bzbarsky: review+
Details | Diff | Splinter Review
v1: Fix QI implementation of HTMLTrackElement r=bz (1.12 KB, patch)
2013-06-13 19:35 PDT, Rick Eyre (:reyre)
no flags Details | Diff | Splinter Review

Description Rick Eyre (:reyre) 2013-06-13 11:16:21 PDT
We're currently getting some assertion errors that we aren't expecting when we run our tests in the test suite.

https://tbpl.mozilla.org/?tree=Try&rev=449474f24c45

This is happening when we check the content load policy for the HTMLTrackElement. We pass in the HTMLTrackElement as an argument, but later Gecko seems to think it's not a window or DOM node and an assertion is thrown.
Comment 1 Rick Eyre (:reyre) 2013-06-13 19:27:09 PDT
Created attachment 762454 [details] [diff] [review]
v1: Fix QI implementation of HTMLTrackElement

https://tbpl.mozilla.org/?tree=Try&rev=9f09df497708

The new tests don't show up in the try changesets added, but if you go to the log you can see them being run.
Comment 2 Boris Zbarsky [:bz] (TPAC) 2013-06-13 19:30:37 PDT
Comment on attachment 762454 [details] [diff] [review]
v1: Fix QI implementation of HTMLTrackElement

r=me
Comment 3 Rick Eyre (:reyre) 2013-06-13 19:35:19 PDT
Created attachment 762460 [details] [diff] [review]
v1: Fix QI implementation of HTMLTrackElement r=bz

Just updated the commit message to include r=bz
Comment 4 Ryan VanderMeulen [:RyanVM] 2013-06-14 06:09:36 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/229c4d26630e
Comment 5 Peter Van der Beken [:peterv] 2013-06-14 06:23:44 PDT
Comment on attachment 762460 [details] [diff] [review]
v1: Fix QI implementation of HTMLTrackElement r=bz

Review of attachment 762460 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/html/content/src/HTMLTrackElement.cpp
@@ +94,3 @@
>  
>  NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION_INHERITED(HTMLTrackElement)
>    NS_INTERFACE_MAP_ENTRY(nsIDOMHTMLElement)

NS_HTML_CONTENT_INTERFACES already deals with nsIDOMHTMLElement so this line is unnecessary.
Comment 6 Rick Eyre (:reyre) 2013-06-14 06:30:45 PDT
Do you want to back this out of the tree then or just a forward fix?
Comment 7 Rick Eyre (:reyre) 2013-06-14 07:11:10 PDT
Peter has recommended on IRC that we can just do a fix in the future. I'll open a bug for that and try to have a patch for it today.
Comment 8 Ryan VanderMeulen [:RyanVM] 2013-06-14 18:59:00 PDT
https://hg.mozilla.org/mozilla-central/rev/229c4d26630e

Note You need to log in before you can comment on or make changes to this bug.