Last Comment Bug 882829 - RNG_SystemRNG should not fall back on rng_systemFromNoise on Windows
: RNG_SystemRNG should not fall back on rng_systemFromNoise on Windows
Product: NSS
Classification: Components
Component: Libraries (show other bugs)
: trunk
: All Windows XP
P2 normal (vote)
: 3.15.1
Assigned To: Wan-Teh Chang
Depends on:
  Show dependency treegraph
Reported: 2013-06-13 11:30 PDT by Wan-Teh Chang
Modified: 2013-07-01 15:35 PDT (History)
3 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

Windows patch (lib/freebl/win_rand.c) (2.93 KB, patch)
2013-06-13 11:30 PDT, Wan-Teh Chang
wtc: checked‑in+
Details | Diff | Splinter Review

Description User image Wan-Teh Chang 2013-06-13 11:30:02 PDT
Created attachment 762187 [details] [diff] [review]
Windows patch (lib/freebl/win_rand.c)

All the major operating systems have a system entropy source:
/dev/urandom on POSIX and RtlGenRandom on Windows.

By default, RNG_SystemRNG should fail (returning 0) rather than
falling back on rng_systemFromNoise if it cannot use the system
entropy source.

The attached Windows patch makes this change to the RNG_SystemRNG
function in lib/freebl/win_rand.c. It also removes the obsolete
code for Windows versions older than Windows XP.
Comment 1 User image Wan-Teh Chang 2013-06-17 18:59:31 PDT
Comment on attachment 762187 [details] [diff] [review]
Windows patch (lib/freebl/win_rand.c)

Ryan reviewed this patch at

Patch checked in:
Comment 2 User image Wan-Teh Chang 2013-07-01 15:35:22 PDT
Edited the bug's summary to reflect what was done in NSS 3.15.1 (Windows only).

Opened bug 889116 to finish this work.

Note You need to log in before you can comment on or make changes to this bug.